All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>
To: gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
	tiwai@suse.de, tj@kernel.org, arjan@linux.intel.com
Cc: teg@jklm.no, rmilasan@suse.com, werner@suse.com, oleg@redhat.com,
	hare@suse.com, bpoirier@suse.de, santosh@chelsio.com,
	pmladek@suse.cz, dbueso@suse.com, mcgrof@suse.com,
	linux-kernel@vger.kernel.org,
	Doug Thompson <dougthompson@xmission.com>,
	Borislav Petkov <bp@alien8.de>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	linux-edac@vger.kernel.org
Subject: [PATCH v1 3/5] amd64_edac: enforce synchronous probe
Date: Fri, 26 Sep 2014 14:57:15 -0700	[thread overview]
Message-ID: <1411768637-6809-4-git-send-email-mcgrof@do-not-panic.com> (raw)
In-Reply-To: <1411768637-6809-1-git-send-email-mcgrof@do-not-panic.com>

From: "Luis R. Rodriguez" <mcgrof@suse.com>

While testing asynchronous PCI probe on this driver I noticed
it failed so enforce just synchronouse probe for now. Asynchronous
probe is not used by default and requires userepace intervention.
Patches for its support will be merged later.

[   14.411083] AMD64 EDAC driver v3.4.0
[   14.411156] bus: 'pci': probe for driver amd64_edac is run asynchronously
[   14.411308] really_probe: driver_sysfs_add(0000:00:18.2) failed
[   14.411354] ------------[ cut here ]------------
[   14.411398] WARNING: CPU: 4 PID: 224 at fs/kernfs/dir.c:1220 kernfs_remove_by_name_ns+0x83/0x90()
[   14.411446] kernfs: can not remove '0000:00:18.2', no directory
[   14.411484] Modules linked in: glue_helper(+) amd64_edac_mod(-) <etc>
[   14.413654] CPU: 4 PID: 224 Comm: kworker/u16:3 Not tainted 3.17.0-rc6+ #1
[   14.413695] Hardware name: To be filled by O.E.M. To be filled by O.E.M./M5A97, BIOS 1605 10/25/2012
[   14.413809] Workqueue: events_unbound driver_attach_workfn
[   14.413909]  0000000000000009 ffffffff814d2cf9 ffff8803f0513d20 ffffffff81061972
[   14.414145]  0000000000000000
[   14.414254]  ffff8803f0513d70
[   14.414383]  ffffffffa032c068 0000000000000038
[   14.414507]  0000000000000000 ffffffff810619d7 ffffffff81723238 ffff880300000020
[   14.414701] Call Trace:
[   14.414746]  [<ffffffff814d2cf9>] ? dump_stack+0x41/0x51
[   14.414790]  [<ffffffff81061972>] ? warn_slowpath_common+0x72/0x90
[   14.414834]  [<ffffffff810619d7>] ? warn_slowpath_fmt+0x47/0x50
[   14.414880]  [<ffffffff814d0ac3>] ? printk+0x4f/0x51
[   14.414921]  [<ffffffff811f8593>] ? kernfs_remove_by_name_ns+0x83/0x90
[   14.415000]  [<ffffffff8137433d>] ? driver_sysfs_remove+0x1d/0x40
[   14.415046]  [<ffffffff81374a15>] ? driver_probe_device+0x1d5/0x250
[   14.415099]  [<ffffffff81374b4b>] ? __driver_attach+0x7b/0x80
[   14.415149]  [<ffffffff81374ad0>] ? __device_attach+0x40/0x40
[   14.415204]  [<ffffffff81372a13>] ? bus_for_each_dev+0x53/0x90
[   14.415254]  [<ffffffff81373913>] ? driver_attach_workfn+0x13/0x80
[   14.415298]  [<ffffffff81077403>] ? process_one_work+0x143/0x3c0
[   14.415342]  [<ffffffff81077a44>] ? worker_thread+0x114/0x480
[   14.415384]  [<ffffffff81077930>] ? rescuer_thread+0x2b0/0x2b0
[   14.415427]  [<ffffffff8107c261>] ? kthread+0xc1/0xe0
[   14.415468]  [<ffffffff8107c1a0>] ? kthread_create_on_node+0x170/0x170
[   14.415511]  [<ffffffff814d883c>] ? ret_from_fork+0x7c/0xb0
[   14.415554]  [<ffffffff8107c1a0>] ? kthread_create_on_node+0x170/0x170
[   14.415595] ---[ end trace dd11ab53a6e1ec0d ]---
[   14.415643] amd64_edac: probe of 0000:00:18.2 failed with error 0

Cc: Tejun Heo <tj@kernel.org>
Cc: Arjan van de Ven <arjan@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Doug Thompson <dougthompson@xmission.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: linux-edac@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Luis R. Rodriguez <mcgrof@suse.com>
---
 drivers/edac/amd64_edac.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index f8bf000..dc997ae 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -2872,6 +2872,7 @@ static struct pci_driver amd64_pci_driver = {
 	.probe		= probe_one_instance,
 	.remove		= remove_one_instance,
 	.id_table	= amd64_pci_table,
+	.driver.sync_probe = true,
 };
 
 static void setup_pci_device(void)
-- 
2.1.0


  parent reply	other threads:[~2014-09-26 21:57 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 21:57 [PATCH v1 0/5] driver-core: async probe support Luis R. Rodriguez
2014-09-26 21:57 ` [Cocci] [PATCH v1 1/5] module: add extra argument for parse_params() callback Luis R. Rodriguez
2014-09-26 21:57   ` Luis R. Rodriguez
2014-09-26 21:57 ` [PATCH v1 2/5] driver-core: enable drivers to opt-out of async probe Luis R. Rodriguez
2014-09-28 14:33   ` Tejun Heo
2014-09-29 18:55     ` Luis R. Rodriguez
2014-09-26 21:57 ` Luis R. Rodriguez [this message]
2014-09-28 14:41   ` [PATCH v1 3/5] amd64_edac: enforce synchronous probe Tejun Heo
2014-09-30  7:23     ` Luis R. Rodriguez
2014-10-01 22:39       ` Luis R. Rodriguez
2014-10-02  9:18         ` Borislav Petkov
2014-10-02 19:08           ` Luis R. Rodriguez
2014-09-26 21:57 ` [PATCH v1 4/5] driver-core: generalize freeing driver private member Luis R. Rodriguez
2014-09-26 21:57 ` [PATCH v1 5/5] driver-core: add driver asynchronous probe support Luis R. Rodriguez
2014-09-26 21:57   ` Luis R. Rodriguez
2014-09-28 15:03   ` Tejun Heo
2014-09-28 15:03     ` Tejun Heo
2014-09-28 15:03     ` Tejun Heo
2014-09-29 21:22     ` Luis R. Rodriguez
2014-09-29 21:22       ` Luis R. Rodriguez
2014-09-29 21:22       ` Luis R. Rodriguez
2014-09-29 21:26       ` Tejun Heo
2014-09-29 21:26         ` Tejun Heo
2014-09-29 21:26         ` Tejun Heo
2014-09-30  7:21         ` Luis R. Rodriguez
2014-09-30  7:21           ` Luis R. Rodriguez
2014-09-30  7:21           ` Luis R. Rodriguez
2014-10-02 23:29           ` Luis R. Rodriguez
2014-10-02 23:29             ` Luis R. Rodriguez
2014-10-02 23:29             ` Luis R. Rodriguez
2014-09-29 21:59       ` Greg KH
2014-09-29 21:59         ` Greg KH
2014-09-29 21:59         ` Greg KH
2014-09-29 22:10         ` Luis R. Rodriguez
2014-09-29 22:10           ` Luis R. Rodriguez
2014-09-29 22:10           ` Luis R. Rodriguez
2014-09-29 22:24           ` Greg KH
2014-09-29 22:24             ` Greg KH
2014-09-29 22:24             ` Greg KH
2014-09-28 17:07   ` Tom Gundersen
2014-09-28 17:07     ` Tom Gundersen
2014-09-28 17:07     ` Tom Gundersen
2014-09-30  2:27     ` Luis R. Rodriguez
2014-09-30  2:27       ` Luis R. Rodriguez
2014-09-30  2:27       ` Luis R. Rodriguez
2014-09-30  7:47       ` Luis R. Rodriguez
2014-09-30  7:47         ` Luis R. Rodriguez
2014-09-30  7:47         ` Luis R. Rodriguez
2014-09-30  9:22       ` Tom Gundersen
2014-09-30  9:22         ` Tom Gundersen
2014-09-30  9:22         ` Tom Gundersen
2014-09-30 15:24         ` Luis R. Rodriguez
2014-09-30 15:24           ` Luis R. Rodriguez
2014-09-30 15:24           ` Luis R. Rodriguez
2014-10-02  6:12           ` Tom Gundersen
2014-10-02  6:12             ` Tom Gundersen
2014-10-02  6:12             ` Tom Gundersen
2014-10-02 20:06             ` Luis R. Rodriguez
2014-10-02 20:06               ` Luis R. Rodriguez
2014-10-02 20:06               ` Luis R. Rodriguez
2014-10-03  8:23               ` Tom Gundersen
2014-10-03  8:23                 ` Tom Gundersen
2014-10-03  8:23                 ` Tom Gundersen
2014-10-03 16:54                 ` Luis R. Rodriguez
2014-10-03 16:54                   ` Luis R. Rodriguez
2014-10-03 16:54                   ` Luis R. Rodriguez
2014-09-28 19:22   ` Dmitry Torokhov
2014-09-28 19:22     ` Dmitry Torokhov
2014-09-28 19:22     ` Dmitry Torokhov
2014-09-30  7:15     ` Luis R. Rodriguez
2014-09-30  7:15       ` Luis R. Rodriguez
2014-09-30  7:15       ` Luis R. Rodriguez
2014-10-02 23:31       ` Luis R. Rodriguez
2014-10-02 23:31         ` Luis R. Rodriguez
2014-10-02 23:31         ` Luis R. Rodriguez
2014-10-03 20:11   ` Luis R. Rodriguez
2014-10-03 20:11     ` Luis R. Rodriguez
2014-10-03 20:11     ` Luis R. Rodriguez
2014-10-03 21:12     ` Luis R. Rodriguez
2014-10-03 21:12       ` Luis R. Rodriguez
2014-10-03 21:12       ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411768637-6809-4-git-send-email-mcgrof@do-not-panic.com \
    --to=mcgrof@do-not-panic.com \
    --cc=arjan@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=bpoirier@suse.de \
    --cc=dbueso@suse.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dougthompson@xmission.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=mcgrof@suse.com \
    --cc=oleg@redhat.com \
    --cc=pmladek@suse.cz \
    --cc=rmilasan@suse.com \
    --cc=santosh@chelsio.com \
    --cc=teg@jklm.no \
    --cc=tiwai@suse.de \
    --cc=tj@kernel.org \
    --cc=werner@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.