From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH] xen: sanity check input and serialize vcpu data in sched_rt.c Date: Mon, 29 Sep 2014 15:26:37 +0200 Message-ID: <1411997197.4336.66.camel@Solace.lan> References: <5422C8BC.3050807@eu.citrix.com> <1411756183-2255-1-git-send-email-mengxu@cis.upenn.edu> <54292FC9020000780003A440@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2829630759658886015==" Return-path: In-Reply-To: <54292FC9020000780003A440@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, xumengpanda@gmail.com, Meng Xu List-Id: xen-devel@lists.xenproject.org --===============2829630759658886015== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-UlMvosmdmn/Is/JSJzAz" --=-UlMvosmdmn/Is/JSJzAz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On lun, 2014-09-29 at 09:09 +0100, Jan Beulich wrote: > >>> On 26.09.14 at 20:29, wrote: > > Sanity check input params in rt_dom_cntl(); > > Serialize rt_dom_cntl() against the global lock; > > Move the call to rt_update_deadline() from _alloc to _insert. >=20 > Regarding this last sentence - the patch clearly does more in this > regard than just move the call from _alloc or _insert. Please make > sure your description matches the patch (which doesn't necessarily > mean enumerating all places it gets moved from - all I'd like to see > is that description and implementation don't disagree). >=20 > And aren't the two changes here independent anyway? In which > case submitting them as two patches might be better? >=20 Indeed, two patch is what we want. Also, the threading. According to my MUA, the mail with the patch is a reply to a message from the v4 patch series. Meng, as this is a new submission, the best thing is always to start a new thread. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-UlMvosmdmn/Is/JSJzAz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlQpXg0ACgkQk4XaBE3IOsQ74QCgkTii2QjAubBOs3fLMrWKJLZU eU0An3df4jjtxEztyzE5O0RToofSgaRa =LBok -----END PGP SIGNATURE----- --=-UlMvosmdmn/Is/JSJzAz-- --===============2829630759658886015== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2829630759658886015==--