From: Luke Suchocki <kernel@suchocki.net>
To: m.chehab@samsung.com
Cc: linux-media@vger.kernel.org
Subject: [PATCH] [media] cx231xx: cx231xx_uninit_bulk attempts to reference and free isoc_ctl instead of bulk_ctl
Date: Mon, 29 Sep 2014 13:41:12 -0500 [thread overview]
Message-ID: <1412016072.9649.15.camel@localhost> (raw)
cx231xx_uninit_bulk() checks that
dev->video_mode.bulk_ctl.transfer_buffer[i] is not NULL, but then calls
usb_free_cohert() with dev->video_mode.isoc_ctl.transfer_buffer[i]
resulting in "BUG: unable to handle NULL pointer dereference" when
closing stream; most likely a cut-and-paste slip from previous
uninit_isoc function.
This will present itself when cx231xx.ko is loaded with
"transfer_mode=0" (USB bulk transfers).
Signed-off-by: Luke Suchocki <kernel@suchocki.net>
--- a/drivers/media/usb/cx231xx/cx231xx-core.c 2014-09-29
13:06:52.006326612 -0500
+++ b/drivers/media/usb/cx231xx/cx231xx-core.c 2014-09-29
13:10:46.796695980 -0500
@@ -943,7 +943,7 @@ void cx231xx_uninit_bulk(struct cx231xx
if (dev->video_mode.bulk_ctl.transfer_buffer[i])
{
usb_free_coherent(dev->udev,
urb->transfer_buffer_length,
-
dev->video_mode.isoc_ctl.
+
dev->video_mode.bulk_ctl.
transfer_buffer[i],
urb->transfer_dma);
reply other threads:[~2014-09-29 18:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412016072.9649.15.camel@localhost \
--to=kernel@suchocki.net \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.