All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <clm@fb.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH RFC] btrfs: introduce procfs interface for the device list
Date: Tue, 30 Sep 2014 10:23:40 -0400	[thread overview]
Message-ID: <1412087020.14485.0@mail.thefacebook.com> (raw)
In-Reply-To: <1411967340-23802-1-git-send-email-anand.jain@oracle.com>



On Mon, Sep 29, 2014 at 1:09 AM, Anand Jain <anand.jain@oracle.com> 
wrote:
> From: Anand Jain <Anand.Jain@oracle.com>
> 
> (added RFC prefix to the patch header)
> (as of now just an experimental interface)
> 
> This patch introduces profs interface /proc/fs/btrfs/devlist,
> which as of now exports all the members of kernel fs_devices.
> 
> The current /sys/fs/btrfs interface works when the fs is
> mounted, and is on the file directory hierarchy and also has
> the sysfs limitation max output of U64 per file.
> 
> Here btrfs procfs uses seq_file to export all the members of
> fs_devices. Also shows the contents when device is not mounted,
> but have registered with btrfs kernel (useful as an alternative
> to buggy ready ioctl)
> 
> An attempt is made to follow the some standard file format
> output such as ini. So that a simple warper python script will
> provide end user useful interfaces.
> 
> Further planning to add few more members to the interface such as
> group profile info. The long term idea is to make procfs
> interface a onestop btrfs application interface for the device and
> fs info from the kernel, where a simple python script can make
> use of it.

Hi Anand,

We're going to have a really hard time getting a new proc interface 
merged in, and after we've recently fixed up all (most?) of our sysfs 
races, I'd rather not have to do it all over again with /proc. I know 
the lack of a seq interface is a difficult compromise to make in sysfs, 
but at this point I think we're stuck with it.  Which specific part do 
you hope to improve by dumping more information out in a single file?

-chris




  reply	other threads:[~2014-09-30 14:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <11967020-23659-1-git-send-email-anand.jain@oracle.com>
2014-09-29  5:09 ` [PATCH RFC] btrfs: introduce procfs interface for the device list Anand Jain
2014-09-30 14:23   ` Chris Mason [this message]
2014-10-01  7:41     ` Anand Jain
2014-10-01 14:09       ` Chris Mason
2014-10-01 23:09         ` Duncan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412087020.14485.0@mail.thefacebook.com \
    --to=clm@fb.com \
    --cc=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.