From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH 15/28] Use configure --libexecdir=BASEDIR to set LIBEXEC Date: Tue, 30 Sep 2014 17:02:38 +0100 Message-ID: <1412092958.31276.25.camel@citrix.com> References: <1411658423-18877-1-git-send-email-olaf@aepfle.de> <1411658423-18877-16-git-send-email-olaf@aepfle.de> <1412092522.31276.16.camel@citrix.com> <20140930155851.GA11949@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140930155851.GA11949@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Wei Liu , Stefano Stabellini , George Dunlap , Ian Jackson , xen-devel@lists.xen.org, Samuel Thibault List-Id: xen-devel@lists.xenproject.org On Tue, 2014-09-30 at 17:58 +0200, Olaf Hering wrote: > On Tue, Sep 30, Ian Campbell wrote: > > > On Thu, 2014-09-25 at 17:20 +0200, Olaf Hering wrote: > > > diff --git a/tools/Makefile b/tools/Makefile > > > index 00f539a..284b73e 100644 > > > --- a/tools/Makefile > > > +++ b/tools/Makefile > > > @@ -86,7 +86,7 @@ uninstall: > > > rm -rf $(D)$(LIBDIR)/libxenstore* $(D)$(LIBDIR)/libxlutil* > > > rm -rf $(D)$(LIBDIR)/python/xen $(D)$(LIBDIR)/python/grub > > > rm -rf $(D)$(LIBDIR)/xen/ > > > - rm -rf $(D)$(LIBEXEC)/xen* > > > + rm -rf $(D)$(LIBEXEC) > > > > Won't this erase ${exec_prefix}/lib? (rather than the xen subtree)? > > No, the internal variable LIBEXEC has to include the subdir name "xen", > otherwise everything would end up in "/usr/lib". An earlier patch in > series adds this change: > > config/Paths.mk.in:LIBEXEC := $(libexecdir)/$(PACKAGE_TARNAME) Ah, ok. thanks Acked-by: Ian Campbell