From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.5] xen/arm64: Make show_registers working even if current is not correctly set Date: Wed, 1 Oct 2014 11:34:14 +0100 Message-ID: <1412159654.4861.11.camel@citrix.com> References: <1412089013-404-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XZHEg-00052H-M0 for xen-devel@lists.xenproject.org; Wed, 01 Oct 2014 10:34:18 +0000 In-Reply-To: <1412089013-404-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, 2014-09-30 at 15:56 +0100, Julien Grall wrote: > The commit 8ab802c "xen/arm: Restricted access to IFSR32_EL2 and FPEXC32_EL2" > introduced the use of the variable current in show_registers. > > The variable is not correctly set until Xen has finished to boot. > Therefore any call to show_registers will result to crash Xen. > > As the register IFSR32_EL2 is only printed when the registers represent > a guest view, Xen can read the value only for this case. > > Signed-off-by: Julien Grall Acked-by: Ian Campbell