From: Ian Campbell <Ian.Campbell@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Ian Jackson <ian.jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH for-xen-4.5] xl: use nic global default values in network-attach
Date: Wed, 1 Oct 2014 13:17:47 +0100 [thread overview]
Message-ID: <1412165867.4861.30.camel@citrix.com> (raw)
In-Reply-To: <1412160405.4861.16.camel@citrix.com>
On Wed, 2014-10-01 at 11:46 +0100, Ian Campbell wrote:
> On Wed, 2014-10-01 at 12:42 +0200, Roger Pau Monne wrote:
> > Introduce a new static function that will be used to set the initial nic
> > config based on the global defaults. This fixes a bug caused by
> > network-attach not using the default values set in xl.conf(5).
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> I'm sure there is more unification which can be done for these things
> but this is a step in the right direction, thanks!
Now applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-10-01 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 10:42 [PATCH for-xen-4.5] xl: use nic global default values in network-attach Roger Pau Monne
2014-10-01 10:46 ` Ian Campbell
2014-10-01 12:17 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412165867.4861.30.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.