From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com
Subject: Re: [PATCH for 4.5] xen/arm64: Make show_registers working even if current is not correctly set
Date: Wed, 1 Oct 2014 13:18:07 +0100 [thread overview]
Message-ID: <1412165887.4861.31.camel@citrix.com> (raw)
In-Reply-To: <1412159654.4861.11.camel@citrix.com>
On Wed, 2014-10-01 at 11:34 +0100, Ian Campbell wrote:
> On Tue, 2014-09-30 at 15:56 +0100, Julien Grall wrote:
> > The commit 8ab802c "xen/arm: Restricted access to IFSR32_EL2 and FPEXC32_EL2"
> > introduced the use of the variable current in show_registers.
> >
> > The variable is not correctly set until Xen has finished to boot.
> > Therefore any call to show_registers will result to crash Xen.
> >
> > As the register IFSR32_EL2 is only printed when the registers represent
> > a guest view, Xen can read the value only for this case.
> >
> > Signed-off-by: Julien Grall <julien.grall@linaro.org>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
Applied.
prev parent reply other threads:[~2014-10-01 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 14:56 [PATCH for 4.5] xen/arm64: Make show_registers working even if current is not correctly set Julien Grall
2014-10-01 10:34 ` Ian Campbell
2014-10-01 12:18 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412165887.4861.31.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.