From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com
Subject: Re: [PATCH v5 for 4.5] xen/arm: Correctly support WARN_ON
Date: Wed, 1 Oct 2014 13:18:20 +0100 [thread overview]
Message-ID: <1412165900.4861.32.camel@citrix.com> (raw)
In-Reply-To: <1412096285-4400-1-git-send-email-julien.grall@linaro.org>
On Tue, 2014-09-30 at 17:58 +0100, Julien Grall wrote:
> Currently the hypervisor will hang if it hits a WARN_ON.
>
> The implementation uses an undefined instruction, made ourself because ARM
> don't provide one, to implement BUG/ASSERT/WARN_ON, and sets up the
> different tables (one for each type) which contain useful information.
>
> This is based on the x86 implementation (include/asm-x86/bug.h). Unfortunately
> the structure can't be shared because many ARM{32,64} gcc versions doesn't
> correctly support %c. The support for executing a function in an exception handler
> is also keep unimplemented on ARM. Therefore, dump_execution_state is
> implemented as WARN()
>
> The current opcode used to go in exception mode may not be undefined on ARM64.
> Use the instruction "brk" to generate a software debug exception.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked...
> ---
> This is a bug fix for Xen 4.5. It make WARN_ON working correctly
> when it has been hit in the hypervisor.
...and applied on that basis.
next prev parent reply other threads:[~2014-10-01 12:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 16:58 [PATCH v5 for 4.5] xen/arm: Correctly support WARN_ON Julien Grall
2014-10-01 12:18 ` Ian Campbell [this message]
2014-10-02 16:56 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412165900.4861.32.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.