All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH v2] sg-report-flight: Add a succcess/failure column header.
Date: Fri, 3 Oct 2014 09:38:58 +0100	[thread overview]
Message-ID: <1412325538.423.5.camel@citrix.com> (raw)
In-Reply-To: <1412269596-27733-1-git-send-email-ian.jackson@eu.citrix.com>

On Thu, 2014-10-02 at 18:06 +0100, Ian Jackson wrote:
> From: Ian Campbell <ian.campbell@citrix.com>
> 
> There are so many rows and columns that scrolling around trying to find the
> column associated with a failure is getting pretty tricky. Finding all failing
> columns is even harder.
> 
> Add a clue near the top: replicate the worst or most interesting step
> result box contents and colour.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> 
> ---
> v2: Do it entirely differently.

The result is indeed better, but it's different enough that I think you
can drop the From:.

Personally I'd have made $cell_html include the "<td" and "</td>" in the
result, since both of the callers just paste it into that context
anyway, but up to you.

Ian.

  reply	other threads:[~2014-10-03  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 11:56 [PATCH OSSTEST] sg-report-flight: Add a succcess/failure column header Ian Campbell
2014-10-02 17:06 ` [OSSTEST PATCH v2] " Ian Jackson
2014-10-03  8:38   ` Ian Campbell [this message]
2014-10-03 11:21     ` Ian Jackson
2014-10-03 12:42       ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412325538.423.5.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.