From: Ian Campbell <Ian.Campbell@citrix.com>
To: Owen Smith <owen.smith@citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Stefano Stabellini <Stefano.Stabellini@citrix.com>,
David Vrabel <david.vrabel@citrix.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: Add comment documentation
Date: Fri, 3 Oct 2014 10:06:04 +0100 [thread overview]
Message-ID: <1412327164.423.15.camel@citrix.com> (raw)
In-Reply-To: <6624BC057AF4E240B6D036F5CC505B12041F5382@AMSPEX01CL02.citrite.net>
On Fri, 2014-09-26 at 11:20 +0100, Owen Smith wrote:
> > > + * page-gref
> > > + * Values: <uint32_t>
> > > + * Only required if "page-ref" is NOT set.
> > > + *
> > > + * A grant reference to the memory page to be mapped for the shared
> > ring
> > > + * structures. Must be present if "page-ref" is not present.
> >
> > Should there be some negotiation for which of page-ref or page-gref is
> > required/preferred by the backend?
> >
> > The same applies to kbdif as well.
> >
>
> I've not added negotiation, as I wanted minimum changes when "page-ref" is specified.
> With the kbdif device only, not investigated the vfb, a backend only supporting "page-gref"
> will break a lot of frontends (I saw breaks in Ubuntu, which advertises both if I forced page-gref)
Is this patch/series documenting existing behaviour or the new behaviour
which you are currently implementing? Both patches have the same title
and essentially the same commit message (list of fields), so I can't
tell.
next prev parent reply other threads:[~2014-10-03 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 9:04 [Qemu-devel] [PATCH 0/2] xenfb: Document public headers Owen smith
2014-09-22 9:04 ` [PATCH 1/2] xenfb: Add comment documentation Owen smith
2014-09-22 9:04 ` [Qemu-devel] " Owen smith
2014-10-08 13:28 ` Stefano Stabellini
2014-10-08 13:28 ` [Qemu-devel] " Stefano Stabellini
2014-09-22 9:04 ` [PATCH 2/2] " Owen smith
2014-09-22 9:04 ` [Qemu-devel] " Owen smith
2014-09-22 10:16 ` [Qemu-devel] [Xen-devel] " David Vrabel
2014-09-22 10:16 ` David Vrabel
2014-09-26 10:20 ` [Qemu-devel] [Xen-devel] " Owen Smith
2014-10-03 9:06 ` Ian Campbell
2014-10-03 9:06 ` Ian Campbell [this message]
2014-09-26 10:20 ` Owen Smith
2014-10-08 13:29 ` Stefano Stabellini
2014-10-08 13:29 ` [Qemu-devel] " Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412327164.423.15.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Stefano.Stabellini@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=owen.smith@citrix.com \
--cc=qemu-devel@nongnu.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.