From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] xen/arm: add support for early printk for
 HiSilicon D01 platform
Date: Fri, 3 Oct 2014 11:29:41 +0100
Message-ID: <1412332181.12695.0.camel@citrix.com>
References: <CAHt6W4fZJJPZ-5iba40WyQwXqUSYniA7szHzTNC+H42Bp2E=VA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAHt6W4fZJJPZ-5iba40WyQwXqUSYniA7szHzTNC+H42Bp2E=VA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Frediano Ziglio <freddy77@gmail.com>
Cc: Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@linaro.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-10-02 at 16:48 +0100, Frediano Ziglio wrote:
> This platform use a standard 8250 device on port 0xe4007000.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>

Acked + applied.

For some reason this didn't hit the list when you posted. Did you get a
bounce? The address looks correct.

NB: if you want the commit author to match your s-o-b and you aren't
sending from your S-o-b address then you need to include a From:
pseudoheader with the "author address".

> ---
>  docs/misc/arm/early-printk.txt | 1 +
>  xen/arch/arm/Rules.mk          | 6 ++++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/docs/misc/arm/early-printk.txt b/docs/misc/arm/early-printk.txt
> index 1431751..92ab0df 100644
> --- a/docs/misc/arm/early-printk.txt
> +++ b/docs/misc/arm/early-printk.txt
> @@ -16,6 +16,7 @@ where mach is the name of the machine:
>    - omap5432: printk with UART3 on TI OMAP5432 processors
>    - sun6i: printk with 8250 on Allwinner A31 processors
>    - sun7i: printk with 8250 on Allwinner A20 processors
> +  - hip04-d01: printk with 8250 on HiSilicon Hip-04 D01
> 
>  The base address and baud rate is hardcoded in xen/arch/arm/Rules.mk,
>  see there when adding support for new machines.
> diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
> index 26fafa2..15f8b09 100644
> --- a/xen/arch/arm/Rules.mk
> +++ b/xen/arch/arm/Rules.mk
> @@ -100,6 +100,12 @@ EARLY_PRINTK_INC := pl011
>  EARLY_PRINTK_BAUD := 115200
>  EARLY_UART_BASE_ADDRESS := 0x7ff80000
>  endif
> +ifeq ($(CONFIG_EARLY_PRINTK), hip04-d01)
> +EARLY_PRINTK_INC := 8250
> +EARLY_PRINTK_BAUD := 115200
> +EARLY_UART_BASE_ADDRESS := 0xE4007000
> +EARLY_UART_REG_SHIFT := 2
> +endif
> 
>  ifneq ($(EARLY_PRINTK_INC),)
>  EARLY_PRINTK := y