All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Konrad Scherer <konrad.scherer@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Makedoc.sh uses home /tmp and fails is noexec is set
Date: Mon, 06 Oct 2014 10:33:25 +0100	[thread overview]
Message-ID: <1412588005.2301.7.camel@ted> (raw)
In-Reply-To: <1412277290-11352-1-git-send-email-konrad.scherer@windriver.com>

On Thu, 2014-10-02 at 15:14 -0400, Konrad Scherer wrote:
> From: Konrad Scherer <Konrad.Scherer@windriver.com>
> 
> The Makedoc.sh script uses the following line to set TMPDIR
> 
> export TMPDIR=`mktemp -d ${TMPDIR:-/tmp}/ldt.XXXXXXXXXX`;
> 
> and then later in the script:
> 
> chmod u+x $TMPDIR/linuxdoc
> 
> Since TMPDIR is not set the script will default to /tmp and if /tmp
> is set to noexec (which is becoming more common), the chmod call fails.
> 
> Signed-off-by: Konrad Scherer <Konrad.Scherer@windriver.com>
> ---
>  meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> index ed6ab73..9bd2bba 100644
> --- a/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> +++ b/meta/recipes-devtools/linuxdoc-tools/linuxdoc-tools-native_0.9.69.bb
> @@ -19,3 +19,7 @@ inherit autotools-brokensep native
>  do_configure () {
>  	oe_runconf
>  }
> +
> +do_install() {
> +	oe_runmake TMPDIR=${T} install
> +}

This actually breaks the builds pretty badly. The fact the image
directory is empty after the above change is a bad sign. The reason is
that it needs to be:

oe_runmake "TMPDIR=${T}" "DESTDIR=${D}" install

If you don't specify DESTDIR, the files in the sysroot disappear and you
get strange errors from recipes like libuser. 

Cheers,

Richard




      reply	other threads:[~2014-10-06  9:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 19:14 [PATCH] Makedoc.sh uses home /tmp and fails is noexec is set Konrad Scherer
2014-10-06  9:33 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412588005.2301.7.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=konrad.scherer@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.