From: Edward L Swarthout <ed.swarthout@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfi_flash: don't hide write/erase errors
Date: Mon, 6 Oct 2014 16:28:10 +0000 [thread overview]
Message-ID: <1412612889243.75883@freescale.com> (raw)
In-Reply-To: <d4639ffb4c3a7ec8391e3c2eea7d13b32d55094e.1409822589.git.baruch@tkos.co.il>
From: Baruch Siach <baruch@tkos.co.il>
> Partially revert commit 0d01f66d235118 (CFI: cfi_flash write fix for AMD
> legacy).
>
> flash_full_status_check() used to skip status register parsing when
> flash_status_check() returns OK. This is wrong since flash_status_check()
> must return OK for other status bits to be valid.
> Cc: Ed Swarthout <Ed.Swarthout@freescale.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
I don't have access to the error case I thought I was fixing with this part
and my change does look incorrect, so
Acked-by: Ed Swarthout <Ed.Swarthout@freescale.com>
Ed
prev parent reply other threads:[~2014-10-06 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 9:23 [U-Boot] [PATCH] cfi_flash: don't hide write/erase errors Baruch Siach
2014-10-06 6:19 ` Baruch Siach
2014-10-06 8:20 ` Stefan Roese
2014-10-06 11:32 ` Baruch Siach
2014-10-06 12:09 ` Stefan Roese
2014-10-06 16:28 ` Edward L Swarthout [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412612889243.75883@freescale.com \
--to=ed.swarthout@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.