From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: David Miller <davem@davemloft.net>, simon.vincent@xsilon.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next] icmp6: Add new icmpv6 type for RPL control message
Date: Tue, 07 Oct 2014 01:53:46 +0200 [thread overview]
Message-ID: <1412639626.712591.175897305.2FA01596@webmail.messagingengine.com> (raw)
In-Reply-To: <20141006.181322.2253854250567400185.davem@davemloft.net>
On Tue, Oct 7, 2014, at 00:13, David Miller wrote:
> From: Simon Vincent <simon.vincent@xsilon.com>
> Date: Mon, 6 Oct 2014 11:37:06 +0100
>
> > IANA has defined a type value of 155 for RPL control messages.
> > We do nothing if we recieve one of these messages. This patch is to
> > avoid getting lots of icmpv6 unknown type messages when using RPL.
> >
> > Signed-off-by: Simon Vincent <simon.vincent@xsilon.com>
>
> If we agree that pretty much our policy is that we treat as "known"
> any ICMPv6 type assigned officially by IANA, then we should simply
> add everything missing from the table at:
>
> http://www.iana.org/assignments/icmpv6-parameters/icmpv6-parameters.xhtml
>
> Any objections?
Might be possible, but I would favor to get rid of the printk or move
the test for informational icmp notifications up.
Some of the type < 128 icmp (non-informal) packets we also report to
user space, so we cannot just add them to a blacklist.
Bye,
Hannes
next prev parent reply other threads:[~2014-10-06 23:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-06 10:37 [PATCH net-next] icmp6: Add new icmpv6 type for RPL control message Simon Vincent
2014-10-06 22:13 ` David Miller
2014-10-06 23:53 ` Hannes Frederic Sowa [this message]
2014-10-07 19:55 ` David Miller
2014-10-07 20:26 ` Hannes Frederic Sowa
2014-10-07 20:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412639626.712591.175897305.2FA01596@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=simon.vincent@xsilon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.