From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: dead qemu make targets in toplevel Makefile Date: Tue, 7 Oct 2014 14:28:46 +0100 Message-ID: <1412688526.4972.24.camel@citrix.com> References: <20141007130727.GA5984@aepfle.de> <1412687768.4972.22.camel@citrix.com> <20141007132611.GA9173@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141007132611.GA9173@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Tue, 2014-10-07 at 15:26 +0200, Olaf Hering wrote: > On Tue, Oct 07, Ian Campbell wrote: > > > It looks like my build scripts use "make -C tools $FOO-force-update", so > > removing them would be a problem for me personally. > > The dead code is in the toplevel Makefile, the command above uses > tools/Makefile. Sorry, I tried to say "would *not* be a problem", because as you note I'm using the tools/Makefile version. > > On the other hand since they are only for use by end users and not > > dependencies of any other rule I suppose we could just nuke the > > conditionals but leave the rules themselves? > > Yes, but shouldnt this be easier like "make update-qemu-trad" which > downloads and forces the tree(s) to be in a given state? And while we > are at it, I find something like "make clean-qemu-trad" useful. It > should check if the subdir is a git tree, and do either a "git clean > -dfx" or "make clean". > > And perhaps all that should be in two easy targets like 'update-subprj' > and 'clean-subprj'. There is likely a better string than "subprj". If you want to go further than simply fixing up the existing things then have at it, I've no in principal objections... Ian.