Re: [PATCH v21] tools: CMDs and APIs for Cache Monitoring Technology

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2014-10-08 at 09:34 +0100, Wei Liu wrote:
> On Wed, Oct 08, 2014 at 04:16:03PM +0800, Chao Peng wrote:
> > Introduced some new xl commands to enable/disable Cache Monitoring
> > Technology(CMT) feature.
> > 
> > The following two commands is to attach/detach the CMT feature
> > to/from a certain domain.
> > 
> > $ xl psr-cmt-attach domid
> > $ xl psr-cmt-detach domid
> > 
> > This command is to display the CMT information, such as L3 cache
> > occupancy.
> > 
> > $ xl psr-cmt-show cache_occupancy <domid>
> > 
> > Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> > Signed-off-by: Chao Peng <chao.p.peng@linux.intel.com>
> 
> Acked-by: Wei Liu <wei.liu2@citrix.com>

Unfortunately this breaks when built on an ARM platform:
xl_cmdimpl.c: In function ‘psr_cmt_print_domain_cache_occupancy’:
xl_cmdimpl.c:7636:5: error: implicit declaration of function ‘libxl_psr_cmt_domain_attached’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c:7644:9: error: implicit declaration of function ‘libxl_psr_cmt_get_cache_occupancy’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c: In function ‘psr_cmt_show_cache_occupancy’:
xl_cmdimpl.c:7659:5: error: implicit declaration of function ‘libxl_psr_cmt_enabled’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c:7674:5: error: implicit declaration of function ‘libxl_psr_cmt_get_total_rmid’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c:7691:9: error: implicit declaration of function ‘libxl_psr_cmt_get_l3_cache_size’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c: In function ‘main_psr_cmt_attach’:
xl_cmdimpl.c:7734:5: error: implicit declaration of function ‘libxl_psr_cmt_attach’ [-Werror=implicit-function-declaration]
xl_cmdimpl.c: In function ‘main_psr_cmt_detach’:
xl_cmdimpl.c:7749:5: error: implicit declaration of function ‘libxl_psr_cmt_detach’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors

The xl side needs appropriate #ifdef's. Since LIBXL_HAVE_PSR_CMT is
already appropriately conditionally defined it seems that basing it on
that would be the correct approach.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel