From: Thomas Monjalon <thomas@monjalon.net>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 4/4] net/failsafe: support secondary process
Date: Tue, 05 Mar 2019 11:00:50 +0100 [thread overview]
Message-ID: <14127814.HFQHTULaMT@xps> (raw)
In-Reply-To: <AM6PR05MB5926F440EA5652BCD2173DE3C2720@AM6PR05MB5926.eurprd05.prod.outlook.com>
05/03/2019 10:33, Raslan Darawsheh:
> Hi Stephen,
>
> From: Stephen Hemminger <stephen@networkplumber.org>
> > On Thu, 28 Feb 2019 15:49:28 +0000
> > Raslan Darawsheh <rasland@mellanox.com> wrote:
> >
> > > + eth_dev->rx_pkt_burst =
> > (eth_rx_burst_t)&failsafe_rx_burst;
> > > + eth_dev->tx_pkt_burst =
> > (eth_tx_burst_t)&failsafe_tx_burst;
> >
> > Why is cast necessary here. The function signature should match.
>
> I don't think it's necessary, but this is the same as the primary process implementation
If it's not necessary, better to not add them.
Don't worry about consistency for pointer casting :)
prev parent reply other threads:[~2019-03-05 10:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 15:49 [PATCH 0/4] support secondary process for failsafe Raslan Darawsheh
2019-02-28 15:49 ` [PATCH 1/4] net/failsafe: replace local device with shared data Raslan Darawsheh
2019-02-28 16:27 ` Thomas Monjalon
2019-02-28 15:49 ` [PATCH 2/4] net/failsafe: change back-reference from sub-device Raslan Darawsheh
2019-02-28 17:16 ` Stephen Hemminger
2019-02-28 15:49 ` [PATCH 3/4] net/failsafe: replace local sub-device with shared data Raslan Darawsheh
2019-02-28 17:22 ` Stephen Hemminger
2019-02-28 15:49 ` [PATCH 4/4] net/failsafe: support secondary process Raslan Darawsheh
2019-02-28 17:23 ` Stephen Hemminger
2019-02-28 17:24 ` Stephen Hemminger
2019-03-05 9:33 ` Raslan Darawsheh
2019-03-05 10:00 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14127814.HFQHTULaMT@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=rasland@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.