From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
linux-kernel@vger.kernel.org, linaro-kernel@lists.linaro.org,
atull@opensource.altera.com, Mark Brown <broonie@kernel.org>
Subject: [PATCH] regulator: of: Lower the severity of the error with no container
Date: Wed, 8 Oct 2014 23:09:59 +0100 [thread overview]
Message-ID: <1412806199-5363-1-git-send-email-broonie@kernel.org> (raw)
Description of regulators should generally be optional so if there is no
DT node for the regulators container then we shouldn't print an error
message. Lower the severity of the message to debug level (it might help
someone work out what went wrong) and while we're at it say what we were
looking for.
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/of_regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 7a51814abdc5..5a1d4afa4776 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -211,7 +211,8 @@ struct regulator_init_data *regulator_of_get_init_data(struct device *dev,
search = dev->of_node;
if (!search) {
- dev_err(dev, "Failed to find regulator container node\n");
+ dev_dbg(dev, "Failed to find regulator container node '%s'\n",
+ desc->regulators_node);
return NULL;
}
--
2.1.1
next reply other threads:[~2014-10-08 22:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 22:09 Mark Brown [this message]
2014-10-08 22:34 ` [PATCH] regulator: of: Lower the severity of the error with no container Guenter Roeck
2014-10-08 22:36 ` Mark Brown
2014-10-08 22:59 ` Guenter Roeck
2014-10-08 23:45 ` Mark Brown
2014-10-09 0:05 ` Guenter Roeck
2014-10-09 0:12 ` Mark Brown
2014-10-09 0:25 ` Guenter Roeck
2014-10-09 15:54 ` Mark Brown
2014-10-09 16:14 ` Guenter Roeck
2014-10-09 17:49 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412806199-5363-1-git-send-email-broonie@kernel.org \
--to=broonie@kernel.org \
--cc=atull@opensource.altera.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.