All of lore.kernel.org
 help / color / mirror / Atom feed
From: David du Colombier <0intro@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] x264: use assembly files on ARMv7
Date: Thu,  9 Oct 2014 10:08:11 +0200	[thread overview]
Message-ID: <1412842091-15386-1-git-send-email-0intro@gmail.com> (raw)

Signed-off-by: David du Colombier <0intro@gmail.com>
---
 package/x264/x264.mk | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/package/x264/x264.mk b/package/x264/x264.mk
index c2397f8..713e37e 100644
--- a/package/x264/x264.mk
+++ b/package/x264/x264.mk
@@ -14,7 +14,7 @@ X264_INSTALL_STAGING = YES
 
 ifeq ($(BR2_i386)$(BR2_x86_64),y)
 	FFMPEG_DEPENDENCIES += host-yasm
-else
+else ifeq ($(BR2_cortex_a5)$(BR2_cortex_a7)$(BR2_cortex_a8)$(BR2_cortex_a9)$(BR2_cortex_a12)$(BR2_cortex_a15),)
 	X264_CONF_OPTS += --disable-asm
 endif
 
@@ -30,9 +30,11 @@ ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),)
 	X264_CONF_OPTS += --disable-thread
 endif
 
-# the configure script is not generated by autoconf
+# The configure script is not generated by autoconf.
+# We need to pass gcc as AS, because the ARM assembly
+# files have to be preprocessed.
 define X264_CONFIGURE_CMDS
-	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure \
+	(cd $(@D); $(TARGET_CONFIGURE_OPTS) AS="$(TARGET_CC)" ./configure \
 		--prefix=/usr \
 		--host="$(GNU_TARGET_NAME)" \
 		--cross-prefix="$(TARGET_CROSS)" \
-- 
1.9.3

             reply	other threads:[~2014-10-09  8:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09  8:08 David du Colombier [this message]
2014-10-09  8:26 ` [Buildroot] [PATCH v2] x264: use assembly files on ARMv7 Thomas Petazzoni
2014-10-09  8:38   ` David du Colombier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412842091-15386-1-git-send-email-0intro@gmail.com \
    --to=0intro@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.