All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
Cc: Roy Franz <roy.franz@linaro.org>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Julien Grall <julien.grall@linaro.org>,
	Vijay Kilari <vijay.kilari@gmail.com>,
	xen-devel <xen-devel@lists.xen.org>
Subject: Re: EFI boot Issue with setup_xenheap_mappings()
Date: Thu, 9 Oct 2014 13:11:36 +0100	[thread overview]
Message-ID: <1412856696.4463.10.camel@citrix.com> (raw)
In-Reply-To: <1412844670.3162.3.camel@citrix.com>

On Thu, 2014-10-09 at 09:51 +0100, Ian Campbell wrote:
> Yes, looking again at the arm64 setup_xenheap_mapping I think it is
> pretty broken when facing non-aligned memory. I think it's just a
> coincidence that EFI happens to expose this (by reserving/fragmenting
> more memory), where u-boot based systems tend not to do so much of that
> sort of thing.

The key turns out to be that where u-boot/dtb presents all of the RAM in
the memory node (which is generally aligned in h/w) and uses the dtb
memreserve function to carve out holes EFI instead registers only the
unreserved RAM to start with, which is more likely to be misaligned.

It is legitimate for EFI to do things this way, so it needs to be fixed.

I've now reproduced locally, including the fix to setup_xenheap_mapping
resulting in an issue accessing the frame table.

I'm still investigating, hopefully I'll have a fix today or tomorrow.

Ian.

      reply	other threads:[~2014-10-09 12:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 23:58 EFI boot Issue with setup_xenheap_mappings() Suravee Suthikulanit
2014-10-09  8:51 ` Ian Campbell
2014-10-09 12:11   ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412856696.4463.10.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=julien.grall@linaro.org \
    --cc=roy.franz@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=vijay.kilari@gmail.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.