Re: [nft PATCH] build: allow disabling libreadline-support

[Steven Barth <cyrus@openwrt.org>]

Hi Pablo, 


> >  
> > -AC_CHECK_LIB([readline], [readline], ,
> > -	     AC_MSG_ERROR([No suitable version of libreadline found]))
> > +
> > +AC_ARG_WITH([libreadline], [AS_HELP_STRING([--without-libreadline],
> > +            [Disable libreadline support (no interactive CLI)])], [],
> > +            [with_libreadline=yes])
> 
> I think, better call this option "without-cli" ?
OK, guess that's fine as well.

> 
> Please, add the:
> 
> #ifdef HAVE_LIBREADLINE
> 
> in cli_init() and cli_exit() in cli.c. It would be good if the cli_init()
> returns a negative value, so you spot the error message below.

The problem I see here that this would basically mean enclosing most of
cli.c in #ifdef HAVE_LIBREADLINE to avoid depending on readline-headers
and having a rather awkward stub of cli_init in the no-readline case.

My main point of excluding cli.c in the Makefile from the start is to
avoid this madness.



Cheers,

Steven