From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] tools/hotplug/Linux: Fix build Date: Fri, 10 Oct 2014 09:35:28 +0100 Message-ID: <1412930128.10650.17.camel@citrix.com> References: <1412872535-8221-1-git-send-email-anthony.perard@citrix.com> <20141009165408.GB12637@aepfle.de> <5436BEC1.9020604@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5436BEC1.9020604@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Anthony PERARD , Olaf Hering , Ian Jackson , Xen Devel List-Id: xen-devel@lists.xenproject.org On Thu, 2014-10-09 at 17:58 +0100, Andrew Cooper wrote: > On 09/10/14 17:54, Olaf Hering wrote: > > On Thu, Oct 09, Anthony PERARD wrote: > > > >> make[6]: Entering directory '/build/xen-unstable/src/xen-unstable/tools/hotplug/Linux' > >> [...] > >> make -C systemd all > >> make -C systemd install > > I wonder why that happens anyway, isnt that the bug? Shouldnt some "all" > > depend on "install", or whatever? > > > > Olaf > > all: should never depend on install. > > all: will be the default target from `make`, which is expected to build > components, and is specifically separate from `make install DESTDIR=$foo` That's true, and as such Olaf's eac3f5122fd4769b2885d8ad78bcbcf5df2472c1 is of course not correct, somehow I didn't manage to notice this. I intend to revert shortly... Ian.