From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH V2] tools/hotplug: Removing of "all" dependency from "install" rule. Date: Tue, 14 Oct 2014 10:58:50 +0100 Message-ID: <1413280730.1497.30.camel@citrix.com> References: <20141010153458.GE1742@perard.uk.xensource.com> <1413210696-10044-1-git-send-email-anthony.perard@citrix.com> <21563.61232.501986.998042@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21563.61232.501986.998042@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: Anthony PERARD , Olaf Hering , Xen Devel List-Id: xen-devel@lists.xenproject.org On Mon, 2014-10-13 at 16:26 +0100, Ian Jackson wrote: > Anthony PERARD writes ("[PATCH V2] tools/hotplug: Removing of "all" dependency from "install" rule."): > > The "install" rules depends on both "all" and "subdirs-install" and > > "all" depends on "subdirs-all". This leads the "install" rules to call > > both "subdirs-all" and "subdirs-install" which create a race with two > > concurrent `make` within the same directory (systemd) trying to make the > > same things (xen.conf) and failing. > > Thanks for the investigation. I think this demonstrates that our > approach to subdirs is, at the very least, excessively fragile. But > this fix (or workaround, if we prefer) will do. > > Acked-by: Ian Jackson Likewise, and applied. Ian.