From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH for-xen-4.5] Adjust helptext in m4/systemd.m4
Date: Tue, 14 Oct 2014 11:01:09 +0100
Message-ID: <1413280869.10417.14.camel@citrix.com>
References: <1412925588-27702-1-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1412925588-27702-1-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-10-10 at 09:19 +0200, Olaf Hering wrote:
> Use AS_HELP_STRING for proper formating, mention both options take a
> directory, mention the default value, quote the arguments in brackets.
> 
> Please rerun autogen.sh after applying this patch.
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>

Acked + applied.

> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  m4/systemd.m4 | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/m4/systemd.m4 b/m4/systemd.m4
> index 760bbad..629d202 100644
> --- a/m4/systemd.m4
> +++ b/m4/systemd.m4
> @@ -18,12 +18,16 @@
>  
>  dnl Some optional path options
>  AC_DEFUN([AX_SYSTEMD_OPTIONS], [
> -	AC_ARG_WITH(systemd, [  --with-systemd          set directory for systemd service files],
> -		SYSTEMD_DIR="$withval", SYSTEMD_DIR="")
> +	AC_ARG_WITH(systemd,
> +		AS_HELP_STRING([--with-systemd=DIR],
> +		[set directory for systemd service files [PREFIX/lib/systemd/system]]),
> +		[SYSTEMD_DIR="$withval"],[SYSTEMD_DIR=""])
>  	AC_SUBST(SYSTEMD_DIR)
>  
> -	AC_ARG_WITH(systemd, [  --with-systemd-modules-load          set directory for systemd modules load files],
> -		SYSTEMD_MODULES_LOAD="$withval", SYSTEMD_MODULES_LOAD="")
> +	AC_ARG_WITH(systemd,
> +		AS_HELP_STRING([--with-systemd-modules-load=DIR],
> +		[set directory for systemd modules load files [PREFIX/lib/modules-load.d/]]),
> +		[SYSTEMD_MODULES_LOAD="$withval"], [SYSTEMD_MODULES_LOAD=""])
>  	AC_SUBST(SYSTEMD_MODULES_LOAD)
>  ])
>