From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-xen-4.5] Remove dead qemu variables from toplevel Makefile Date: Tue, 14 Oct 2014 11:01:29 +0100 Message-ID: <1413280889.10417.16.camel@citrix.com> References: <1412933005-25973-1-git-send-email-olaf@aepfle.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1412933005-25973-1-git-send-email-olaf@aepfle.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Olaf Hering Cc: Wei Liu , Ian Jackson , Stefano Stabellini , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Fri, 2014-10-10 at 11:23 +0200, Olaf Hering wrote: > The variables should have been removed already in > 7ed06911dc596d23f21dee209b7f2db294e34b56 ("Remove dead qemu code from > toplevel Makefile"), but I did not spot it at this time. > Now it looks like the intention initially was to let the install-tools > depend on tools/qemu-xen-traditional-dir. But that did not work because > there was the typo in the variables (TGT vs. TARGET), and > CONFIG_QEMU_TRAD was not defined anyway. > > So remove QEMU_TRAD_DIR_TARGET and QEMU_XEN_DIR_TARGET because they are > not defined at all. > > Signed-off-by: Olaf Hering Acked + applied.