All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Scott Branden <sbranden@broadcom.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Antti Palosaari <crope@iki.fi>, Jingoo Han <jg1.han@samsung.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	swarren@wwwdotorg.org
Subject: Re: get_maintainers.pl doesn't actually get the real MAINTAINERS?
Date: Tue, 14 Oct 2014 19:42:24 -0700	[thread overview]
Message-ID: <1413340944.7475.5.camel@perches.com> (raw)
In-Reply-To: <543DDC6D.8030701@broadcom.com>

On Tue, 2014-10-14 at 19:31 -0700, Scott Branden wrote:
> On 14-10-14 07:26 PM, Joe Perches wrote:
> > On Tue, 2014-10-14 at 19:18 -0700, Scott Branden wrote:
> >> Hello,
> >>
> >> I try running scripts/get_maintainers.pl but it doesn't seem to get the
> >> real maintainers properly.  Please note this is run against the current
> >> MAINTAINERS file.
> >>
> >> One Example:  I would expect drivers/mmc/host/sdhci-bcm2835.c to be
> >> maintained by Stephen Warren based on drivers/*/*bcm2835* below.
> >
> > get_maintainers doesn't use * as a depth wildcard
> >
> > */ matches a single top level directory level
> > */*/ matches one level below the top directory level.
> >
> >>    But
> >> the get_maintainers.pl script does not seem to process the information
> >> in such a way.  So what needs to be corrected - the script or the syntax
> >> used in the MAINTAINERS file?
> >>
> >> BROADCOM BCM2835 ARM ARCHICTURE
> >> M:	Stephen Warren <swarren@wwwdotorg.org>
> >> L:	linux-rpi-kernel@lists.infradead.org (moderated for non-subscribers)
> >> T:	git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-rpi.git
> >> S:	Maintained
> >> F:	arch/arm/mach-bcm/board_bcm2835.c
> >> F:	arch/arm/boot/dts/bcm2835*
> >> F:	arch/arm/configs/bcm2835_defconfig
> >> F:	drivers/*/*bcm2835*
> >
> > F:	drivers/*/*/*bmc2835*
> Thanks for the explanation.  So somebody should really do the following 
> to maintain any files no matter where they are located?
> F:	*/*bcm2835*
> F:	*/*/*bcm2835*
> F:	*/*/*/*bcm2835*
> F:	*/*/*/*/*bcm2835*
> F:	*/*/*/*/*/*bcm2835*
> F:	*/*/*/*/*/*/*bcm2835*
> F:	*/*/*/*/*/*/*/*bcm2835*
> 
> Or, can a recursive option be added in the script?

Hasn't been much of a need for that but knock yourself
out if you think something like a ... might be useful.

Look for function "file_match_pattern" if you want
to extend it.

There is a file name matching option "N:" that
does something similar.

Difference is that F: patterns matches do not
use git history by default to find other people
that have submitted patches, N: does.



      reply	other threads:[~2014-10-15  2:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-15  2:18 get_maintainers.pl doesn't actually get the real MAINTAINERS? Scott Branden
2014-10-15  2:26 ` Joe Perches
2014-10-15  2:31   ` Scott Branden
2014-10-15  2:42     ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413340944.7475.5.camel@perches.com \
    --to=joe@perches.com \
    --cc=akpm@linux-foundation.org \
    --cc=crope@iki.fi \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=sbranden@broadcom.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.