From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 for 4.5] arm32: fix build after 063188f4b3
Date: Wed, 15 Oct 2014 09:11:29 +0100
Message-ID: <1413360689.10417.80.camel@citrix.com>
References: <1413304323-4639-1-git-send-email-julien.grall@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XeJgE-0001La-On
	for xen-devel@lists.xenproject.org; Wed, 15 Oct 2014 08:11:34 +0000
In-Reply-To: <1413304323-4639-1-git-send-email-julien.grall@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, Jan Beulich <jbeulich@suse.com>, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-10-14 at 17:32 +0100, Julien Grall wrote:
> @@ -263,7 +250,7 @@ static int exynos5_cpu_up(int cpu)
>      iounmap(power);
>  
>      if ( secure_firmware )
> -        exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0);
> +        call_smc1(SMC_CMD_CPU1BOOT, cpu);
>  

Have you confirmed that none of these zeroes (throughout the patch, not
just here) are actually unused and not just formal parameters which
happen to be zero.

For example:

> -    return __invoke_psci_fn_smc(psci_cpu_on_nr,
> -                                cpu_logical_map(cpu), __pa(init_secondary), 0);
> +    return call_smc2(psci_cpu_on_nr, cpu_logical_map(cpu), __pa(init_secondary));

CPU_ON takes three arguments, target_cpu, entry_point_address and
context_id, so the zero here is actually the context_id parameter and
not a dummy argument.

> +#elif defined(CONFIG_ARM_64)
> +/* Not specific ARM64 macros for now */

"No specific..."

> +
> +int do_smc(register_t function_id, ...);

Stray?

Ian.