All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jiri Slaby <jslaby@suse.cz>,
	One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
	Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH -next 08/10] serial: core: Colocate crucial structure linkage
Date: Thu, 16 Oct 2014 16:54:25 -0400	[thread overview]
Message-ID: <1413492867-20679-9-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <1413492867-20679-1-git-send-email-peter@hurleysoftware.com>

The key function of uart_add_one_port() is to cross-reference the
UART driver's port structure with the serial core's state table;
keep the assignments together and document this crucial association.

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
 drivers/tty/serial/serial_core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 676c03a..e04ae58 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -2594,11 +2594,12 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
 		goto out;
 	}
 
+	/* Link the port to the driver state table and vice versa */
 	state->uart_port = uport;
-	state->pm_state = UART_PM_STATE_UNDEFINED;
+	uport->state = state;
 
+	state->pm_state = UART_PM_STATE_UNDEFINED;
 	uport->cons = drv->cons;
-	uport->state = state;
 
 	/*
 	 * If this port is a console, then the spinlock is already
-- 
2.1.1

  parent reply	other threads:[~2014-10-16 20:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 20:54 [PATCH -next 00/10] serial core fixes Peter Hurley
2014-10-16 20:54 ` [PATCH -next 01/10] serial: Refactor uart_flush_buffer() from uart_close() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 02/10] serial: core: Flush ldisc after dropping port mutex in uart_close() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 03/10] serial: Fix locking for uart driver set_termios() method Peter Hurley
2014-10-16 20:54 ` [PATCH -next 04/10] tty,serial: Unify UPF_* and ASYNC_* flag definitions Peter Hurley
2014-10-16 20:54 ` [PATCH -next 05/10] tty: Document defunct ASYNC_* bits in uapi header Peter Hurley
2014-10-17  8:46   ` Jiri Slaby
2014-10-17 12:44     ` Peter Hurley
2014-10-17 13:31       ` Jiri Slaby
2014-11-06  2:53         ` Greg Kroah-Hartman
2014-10-16 20:54 ` [PATCH -next 06/10] serial: core: Unwrap >80 char line in uart_close() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 07/10] serial: core: Remove redundant timeout assignments Peter Hurley
2014-10-16 20:54 ` Peter Hurley [this message]
2014-10-16 20:54 ` [PATCH -next 09/10] serial: core: Remove extra locking in uart_write() Peter Hurley
2014-10-16 20:54 ` [PATCH -next 10/10] serial: core: Fix port count when uart_open() errors Peter Hurley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413492867-20679-9-git-send-email-peter@hurleysoftware.com \
    --to=peter@hurleysoftware.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.