From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 for 4.5] arm32: fix build after 063188f4b3 Date: Mon, 20 Oct 2014 11:49:40 +0100 Message-ID: <1413802180.11781.6.camel@citrix.com> References: <1413462858-17951-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XgAXH-0007CQ-BP for xen-devel@lists.xenproject.org; Mon, 20 Oct 2014 10:49:59 +0000 In-Reply-To: <1413462858-17951-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, Jan Beulich , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2014-10-16 at 13:34 +0100, Julien Grall wrote: > "xen: arm: Add support for the Exynos secure firmware" introduced code > assuming that exynos_smc() would get called with arguments in certain > registers. While the "noinline" attribute guarantees the function to > not get inlined, it does not guarantee that all arguments arrive in the > assumed registers: gcc's interprocedural analysis can result in clone > functions to be created where some of the incoming arguments (commonly > when they have constant values) get replaced by putting in place the > respective values inside the clone. > > Xen contains in multiple place of this SMC function: consolidate the function > in a single place and write it in assembly. > > Reported-by: Jan Beulich > Signed-off-by: Julien Grall Acked-by: Ian Campbell I think a better $subject would be "xen: arm: introduce assembly helper to call smc" and to begin the body with: Commit 063188f4b3 "xen: arm: Add support for..." If that's OK with you I'll make that change as I commit. Ian.