From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v5 for 4.5] arm32: fix build after 063188f4b3
Date: Mon, 20 Oct 2014 14:19:51 +0100
Message-ID: <1413811191.4087.21.camel@citrix.com>
References: <1413462858-17951-1-git-send-email-julien.grall@linaro.org>
	<1413802180.11781.6.camel@citrix.com> <5444E95A.2040107@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XgCsw-0004Id-2m
	for xen-devel@lists.xenproject.org; Mon, 20 Oct 2014 13:20:30 +0000
In-Reply-To: <5444E95A.2040107@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, Jan Beulich <jbeulich@suse.com>, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-10-20 at 11:52 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 10/20/2014 11:49 AM, Ian Campbell wrote:
> > On Thu, 2014-10-16 at 13:34 +0100, Julien Grall wrote:
> >> "xen: arm: Add support for the Exynos secure firmware" introduced code
> >> assuming that exynos_smc() would get called with arguments in certain
> >> registers. While the "noinline" attribute guarantees the function to
> >> not get inlined, it does not guarantee that all arguments arrive in the
> >> assumed registers: gcc's interprocedural analysis can result in clone
> >> functions to be created where some of the incoming arguments (commonly
> >> when they have constant values) get replaced by putting in place the
> >> respective values inside the clone.
> >>
> >> Xen contains in multiple place of this SMC function: consolidate the function
> >> in a single place and write it in assembly.
> >>
> >> Reported-by: Jan Beulich <jbeulich@suse.com>
> >> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> > 
> > I think a better $subject would be "xen: arm: introduce assembly helper
> > to call smc" and to begin the body with:
> >         Commit 063188f4b3 "xen: arm: Add support for..."
> > 
> > If that's OK with you I'll make that change as I commit.
> 
> I fine with it.

Done. thanks.

Ian.