From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: xen-devel@lists.xenproject.org, tim@xen.org,
stefano.stabellini@citrix.com
Subject: Re: [PATCH for 4.5] xen/arm: p2m: Fix crash when p2m_lookup is used with an invalid IPA
Date: Mon, 20 Oct 2014 14:21:05 +0100 [thread overview]
Message-ID: <1413811265.4087.24.camel@citrix.com> (raw)
In-Reply-To: <1413660321-14620-1-git-send-email-julien.grall@linaro.org>
On Sat, 2014-10-18 at 20:25 +0100, Julien Grall wrote:
> Since the commit 58f0fd8 "xen: arm: handle variable p2m levels in p2m_lookup",
> Xen checks that the root_table offset is valid. If not, its unlock the p2m
> spinlock before returning an error. But, at this time, the lock has not been
> taken.
>
> On Xen built with debug=y, we can get the following stack trace if the guest
> use an invalid IPA in hypercall or mess-up the grant-table:
>
> (XEN) Assertion '_raw_spin_is_locked(lock)' failed at xen/include/asm/arm32/spinlock.h:22
> ...
> (XEN) [<0022d1bc>] _spin_unlock+0x2c/0x50 (PC)
> (XEN) [<00253264>] p2m_lookup+0x20c/0x230 (LR)
> (XEN) [<7ffdfd54>] 7ffdfd54
> (XEN) [<002539f4>] gmfn_to_mfn+0x24/0x3c
> (XEN) [<0020e4d4>] __get_paged_frame+0x30/0x12c
> (XEN) [<00210680>] __acquire_grant_for_copy+0x4e0/0x768
> (XEN) [<00212030>] do_grant_table_op+0x13a0/0x2534
> (XEN) [<00257b10>] do_trap_hypervisor+0xe10/0x1148
> (XEN) [<0025b330>] return_from_trap+0/0x4
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
acked + applied, thanks.
prev parent reply other threads:[~2014-10-20 13:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-18 19:25 [PATCH for 4.5] xen/arm: p2m: Fix crash when p2m_lookup is used with an invalid IPA Julien Grall
2014-10-20 13:21 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413811265.4087.24.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.