From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for 4.5] xen/arm: flush_tlb_domain: Disable IRQ when flushing TLB of another domain Date: Mon, 20 Oct 2014 14:21:18 +0100 Message-ID: <1413811278.4087.25.camel@citrix.com> References: <1413562484-13383-1-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XgCtn-0004Sm-DJ for xen-devel@lists.xenproject.org; Mon, 20 Oct 2014 13:21:23 +0000 In-Reply-To: <1413562484-13383-1-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2014-10-17 at 17:14 +0100, Julien Grall wrote: > When Xen is flushing the TLB for another domain than current, it has to > switch temporaly to the P2M of this domain. If the IRQs are enabled, it may > be possible to receive an interrupt that require to use the P2M of the current > domain, or even temporaly switch to another P2M. > For the former case, the translation would be wrong. For the latter one, > as the handler would restore the current P2M, Xen would flush the wrong domain > TLB. > > Thankfully we don't have such interrupt handler, but it may be necessary > in the future to do that during when the user asks to dump domain stack via > a keystroke. > > Signed-off-by: Julien Grall Acked + applied as a bug fix. I fixed the spelling of temporarily for you as I went, and fixed up some grammar. Ian.