From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-xen-4.5] tools/hotplug: update
 dependency of var-lib-xenstored.mount
Date: Mon, 20 Oct 2014 15:35:09 +0100
Message-ID: <1413815709.13796.14.camel@citrix.com>
References: <1413366087-5805-1-git-send-email-olaf@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1413366087-5805-1-git-send-email-olaf@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-10-15 at 11:41 +0200, Olaf Hering wrote:
> After previous change which uses /proc/xen/capabilities as condition the
> unit file has now a dependency on proc-xen.mount. Add a Requires= to let
> this unit fail if proc-xen.mount fails. Add an After= as ordering hint.
> 
> This was noticed with a pvops dom0, in a xenlinux dom0 the proc file is
> always present.

Should this be folded into "tools/hotplug: fix systemd service files for
dom0"?

> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
> 
> This is finally tested with a 3.17 pvops dom0.
> 
>  tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> index 64b560f..d5e04db 100644
> --- a/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> +++ b/tools/hotplug/Linux/systemd/var-lib-xenstored.mount.in
> @@ -1,5 +1,7 @@
>  [Unit]
>  Description=mount xenstore file system
> +Requires=proc-xen.mount
> +After=proc-xen.mount
>  ConditionPathExists=/proc/xen/capabilities
>  RefuseManualStop=true
>