From: Alvaro Neira Ayuso <alvaroneay@gmail.com>
To: netfilter-devel@vger.kernel.org
Cc: kaber@trash.net
Subject: [nft PATCH 2/4] evaluate: accept a reject reason with incorrect network context
Date: Tue, 21 Oct 2014 01:29:38 +0200 [thread overview]
Message-ID: <1413847780-10149-2-git-send-email-alvaroneay@gmail.com> (raw)
In-Reply-To: <1413847780-10149-1-git-send-email-alvaroneay@gmail.com>
nft add rule bridge test-bridge input ether type ip \
reject with icmpv6 type no-route
This rule pass the evaluation step but the network context is incompatible with
the reject reason. In that cases, we have to throw an error like "conflicting
protocols specified: ip vs ip6"
Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
---
src/evaluate.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/evaluate.c b/src/evaluate.c
index 977df86..20235a8 100644
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -1248,6 +1248,8 @@ static int stmt_evaluate_reject_bridge(struct eval_ctx *ctx, struct stmt *stmt,
case __constant_htons(ETH_P_IP):
if (NFPROTO_IPV4 == stmt->reject.family)
return 0;
+ return stmt_error(ctx, stmt,
+ "conflicting protocols specified: ip vs ip6");
case __constant_htons(ETH_P_IPV6):
if (NFPROTO_IPV6 == stmt->reject.family)
return 0;
--
1.7.10.4
next prev parent reply other threads:[~2014-10-20 23:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 23:29 [nft PATCH 1/4] evaluate: refactor function to check the reject family in inet and bridge Alvaro Neira Ayuso
2014-10-20 23:29 ` Alvaro Neira Ayuso [this message]
2014-10-20 23:29 ` [nft PATCH 3/4] evaluate: no check the network context in reject with tcp reset reason Alvaro Neira Ayuso
2014-10-21 7:55 ` Pablo Neira Ayuso
2014-10-21 12:32 ` Álvaro Neira Ayuso
2014-10-20 23:29 ` [nft PATCH 4/4 v3] evaluate: fix a crash if we check the transport protocol is tcp Alvaro Neira Ayuso
2014-10-21 8:15 ` Pablo Neira Ayuso
2014-10-21 12:28 ` Álvaro Neira Ayuso
2014-10-21 8:45 ` [nft PATCH 1/4] evaluate: refactor function to check the reject family in inet and bridge Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413847780-10149-2-git-send-email-alvaroneay@gmail.com \
--to=alvaroneay@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.