From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for 4.5 v7 1/1] Add mmio_hole_size
Date: Tue, 21 Oct 2014 08:57:20 +0100
Message-ID: <1413878240.20604.21.camel@citrix.com>
References: <1413204679-7345-1-git-send-email-dslutz@verizon.com>
	<1413204679-7345-2-git-send-email-dslutz@verizon.com>
	<1413814677.13796.10.camel@citrix.com> <54458621.3080102@terremark.com>
	<54462B6802000078000408A0@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54462B6802000078000408A0@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, xen-devel@lists.xen.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-10-21 at 08:46 +0100, Jan Beulich wrote:
> >>> On 21.10.14 at 00:01, <dslutz@verizon.com> wrote:
> > On 10/20/14 10:17, Ian Campbell wrote:
> >> On Mon, 2014-10-13 at 08:51 -0400, Don Slutz wrote:
> >>> --- a/tools/libxl/libxl_types.idl
> >>> +++ b/tools/libxl/libxl_types.idl
> >>> @@ -391,6 +391,7 @@ libxl_domain_build_info = Struct("domain_build_info",[
> >>>                                          ("timeoffset",       string),
> >>>                                          ("hpet",             libxl_defbool),
> >>>                                          ("vpt_align",        libxl_defbool),
> >>> +                                       ("mmio_hole_size",   uint64),
> >> Please make this a MemKB at the libxl interface level and convert
> >> internally to whatever hvmloader expects. It seems that a more
> >> conventional name would also have a _memkb suffix. Perhaps
> >> mmio_hole_memkb? (size seems to be implicit to me).
> >>
> > 
> > Ok, Jan Beulich had proposed the name with the _size (on 27 Jun 2014), 
> > but he
> > did also say "(whether the xl config option should also get renamed I'm not
> > sure - the xl maintainers will know )", (so I am taking this as ok from 
> > Jan) I will
> > rename to mmio_hole_memkb here.
> 
> My remark was really intended for you to actively inquire about the
> config option name.

Or better yet, look at the existing examples for both libxl API and xl
configuration file names and if you aren't sure then ask.

foo_memkb is conventional in the libxl interface. For the xl.cfg level
the units are typically mbytes and the names unitless (i.e. no _memkb
suffix), often due to xm legacy. The existing xl.cfg names are things
like "memory", "maxmem", "shadow_memory", "videoram". I think mmio_hole
or mmio_hole_size would be a good enough name for xl.cfg.

Ian.