From: Ian Campbell <Ian.Campbell@citrix.com>
To: Roy Franz <roy.franz@linaro.org>
Cc: tim@xen.org, stefano.stabellini@citrix.com,
Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
fu.wei@linaro.org, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen/arm64: Use __flush_dcache_area instead of __flush_dcache_all
Date: Tue, 21 Oct 2014 09:17:24 +0100 [thread overview]
Message-ID: <1413879444.20604.29.camel@citrix.com> (raw)
In-Reply-To: <1413863725-27630-1-git-send-email-roy.franz@linaro.org>
On Mon, 2014-10-20 at 20:55 -0700, Roy Franz wrote:
[...]
> - * void noreturn efi_xen_start(void *fdt_ptr);
> + * void noreturn efi_xen_start(void *fdt_ptr, uint32_t fdt_size);
> */
> ENTRY(efi_xen_start)
> /*
> + * Preserve x0 (fdt pointer) across call to __flush_dcache_area,
> + * restore for entry into Xen.
> + */
> + mov x20, x0
> +
> + /* flush dcache covering the FDT updated by EFI boot code */
According to the above strictly speaking the length is in w1 rather than
x1. However I'm fairly certain (without having checked) that assigning
to wn clears the upper 32-bits so this is fine. Hence:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
and applied.
If I'm misremembering about the writes to wn please holler ;-)
> + ic ialluis
> + tlbi alle2
I added a space here to line up the alle2.
Ian.
next prev parent reply other threads:[~2014-10-21 8:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 3:55 [PATCH] xen/arm64: Use __flush_dcache_area instead of __flush_dcache_all Roy Franz
2014-10-21 3:57 ` Roy Franz
2014-10-21 8:17 ` Ian Campbell [this message]
2014-10-21 14:17 ` Remaining EFI Xen on ARM issues (on Juno at least) Ian Campbell
2014-10-22 3:59 ` Roy Franz
2014-10-22 8:47 ` Ian Campbell
2014-10-22 9:51 ` Jan Beulich
2014-10-22 10:45 ` Ian Campbell
2014-10-22 14:14 ` Jan Beulich
2014-10-22 14:24 ` Ian Campbell
2014-10-22 14:31 ` Jan Beulich
2014-10-23 22:49 ` Roy Franz
2014-10-25 0:29 ` Roy Franz
-- strict thread matches above, loose matches on Subject: below --
2014-10-06 15:49 [PATCH] xen/arm64: Use __flush_dcache_area instead of __flush_dcache_all suravee.suthikulpanit
2014-10-06 16:28 ` Mark Rutland
2014-10-07 4:15 ` Roy Franz
2014-10-07 9:32 ` Ian Campbell
2014-10-07 10:40 ` Mark Rutland
2014-10-14 3:48 ` Roy Franz
2014-10-14 9:21 ` Mark Rutland
2014-10-14 9:35 ` Ian Campbell
2014-10-14 10:32 ` Mark Rutland
2014-10-14 10:39 ` Ian Campbell
2014-10-14 11:23 ` Mark Rutland
2014-10-14 12:54 ` Ian Campbell
2014-10-14 14:30 ` Mark Rutland
2014-10-14 16:26 ` Roy Franz
2014-10-14 17:07 ` Mark Rutland
2014-10-14 17:19 ` Roy Franz
2014-10-15 8:02 ` Ian Campbell
2014-10-15 15:02 ` Stefano Stabellini
2014-10-07 9:27 ` Ian Campbell
2014-10-07 10:52 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413879444.20604.29.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=fu.wei@linaro.org \
--cc=roy.franz@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.