From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH RFC 2/3] systemd: add xen-init-dom0 service
Date: Tue, 21 Oct 2014 09:49:52 +0100
Message-ID: <1413881392.29506.17.camel@citrix.com>
References: <1413817309-4884-1-git-send-email-wei.liu2@citrix.com>
	<1413817309-4884-3-git-send-email-wei.liu2@citrix.com>
	<1413831206.97460.YahooMailNeo@web162405.mail.bf1.yahoo.com>
	<20141020202759.GA21346@zion.uk.xensource.com>
	<20141021072744.GA10846@aepfle.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141021072744.GA10846@aepfle.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Olaf Hering <olaf@aepfle.de>
Cc: Mark Pryor <tlviewer@yahoo.com>, "mcgrof@do-not-panic.com" <mcgrof@do-not-panic.com>, Wei Liu <wei.liu2@citrix.com>, "ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-10-21 at 09:27 +0200, Olaf Hering wrote:
> On Mon, Oct 20, Wei Liu wrote:
> 
> > diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in b/tools/hotplug/Linux/systemd/xenstored.service.in
> > index 013e69e..e3bf837 100644
> > --- a/tools/hotplug/Linux/systemd/xenstored.service.in
> > +++ b/tools/hotplug/Linux/systemd/xenstored.service.in
> > @@ -17,8 +17,6 @@ ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
> >  ExecStartPre=-/bin/rm -f @XEN_LIB_STORED@/tdb*
> >  ExecStartPre=/bin/mkdir -p @XEN_RUN_DIR@
> >  ExecStart=/bin/sh -c "exec $XENSTORED --no-fork $XENSTORED_ARGS"
> > -ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/name" "Domain-0"
> > -ExecStartPost=-@bindir@/xenstore-write "/local/domain/0/domid" 0
> 
> This should have been in ae931f568fe9e91179f3ff3aab199a84d39a626b
> ("libxl: introduce helper to initialise Dom0").

Since that commit didn't adjust the systemd integration I don't think
that's right. I'm expecting Wei will include it in the eventual patch
set to switch systemd over to the new helper.

> 
> 
> Acked-by: Olaf Hering <olaf@aepfle.de>
> 
> 
> Olaf