From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v8 6/8] xen/arm: introduce
	GNTTABOP_cache_flush
Date: Tue, 21 Oct 2014 10:04:12 +0100
Message-ID: <1413882252.23337.3.camel@citrix.com>
References: <alpine.DEB.2.02.1410201044080.17038@kaball.uk.xensource.com>
	<1413798499-28314-6-git-send-email-stefano.stabellini@eu.citrix.com>
	<1413818668.29506.7.camel@citrix.com>
	<544546CE02000078000405EB@mail.emea.novell.com>
	<alpine.DEB.2.02.1410201730500.876@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1410201730500.876@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: julien.grall@citrix.com, xen-devel@lists.xensource.com, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2014-10-20 at 17:31 +0100, Stefano Stabellini wrote:
> On Mon, 20 Oct 2014, Jan Beulich wrote:
> > >>> On 20.10.14 at 17:24, <Ian.Campbell@citrix.com> wrote:
> > > On Mon, 2014-10-20 at 10:48 +0100, Stefano Stabellini wrote:
> > >>  
> > >> @@ -574,6 +576,25 @@ struct gnttab_swap_grant_ref {
> > >>  typedef struct gnttab_swap_grant_ref gnttab_swap_grant_ref_t;
> > >>  DEFINE_XEN_GUEST_HANDLE(gnttab_swap_grant_ref_t);
> > >>  
> > >> +/*
> > >> + * Issue one or more cache maintenance operations on a portion of a
> > >> + * page granted to the calling domain by a foreign domain.
> > >> + */
> > >> +struct gnttab_cache_flush {
> > >> +    union {
> > >> +        uint64_t dev_bus_addr;
> > >> +        grant_ref_t ref;
> > >> +    } a;
> > >> +    uint16_t offset; /* offset from start of grant */
> > >> +    uint16_t length; /* size within the grant */
> > > 
> > > So are these not valid when used with dev_bus_addr? I can see that being
> > > the case for offset, but length too?
> > 
> > Both ought to be valid, and dev_bus_addr should be page aligned.
> 
> That's right.

I would have expected you to correct the comment in the repost then
(which I notice also still says arm in the subject)

Ian.