From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH v8 6/8] xen/arm: introduce
	GNTTABOP_cache_flush
Date: Tue, 21 Oct 2014 10:35:33 +0100
Message-ID: <1413884133.23337.13.camel@citrix.com>
References: <alpine.DEB.2.02.1410201044080.17038@kaball.uk.xensource.com>
	<1413798499-28314-6-git-send-email-stefano.stabellini@eu.citrix.com>
	<1413818668.29506.7.camel@citrix.com>
	<544546CE02000078000405EB@mail.emea.novell.com>
	<alpine.DEB.2.02.1410201730500.876@kaball.uk.xensource.com>
	<1413882252.23337.3.camel@citrix.com>
	<544640270200007800040932@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XgVqr-0003iL-Qs
	for xen-devel@lists.xenproject.org; Tue, 21 Oct 2014 09:35:37 +0000
In-Reply-To: <544640270200007800040932@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: julien.grall@citrix.com, xen-devel <xen-devel@lists.xenproject.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2014-10-21 at 10:14 +0100, Jan Beulich wrote:
> >>> On 21.10.14 at 11:04, <Ian.Campbell@citrix.com> wrote:
> > On Mon, 2014-10-20 at 17:31 +0100, Stefano Stabellini wrote:
> >> On Mon, 20 Oct 2014, Jan Beulich wrote:
> >> > >>> On 20.10.14 at 17:24, <Ian.Campbell@citrix.com> wrote:
> >> > > On Mon, 2014-10-20 at 10:48 +0100, Stefano Stabellini wrote:
> >> > >>  
> >> > >> @@ -574,6 +576,25 @@ struct gnttab_swap_grant_ref {
> >> > >>  typedef struct gnttab_swap_grant_ref gnttab_swap_grant_ref_t;
> >> > >>  DEFINE_XEN_GUEST_HANDLE(gnttab_swap_grant_ref_t);
> >> > >>  
> >> > >> +/*
> >> > >> + * Issue one or more cache maintenance operations on a portion of a
> >> > >> + * page granted to the calling domain by a foreign domain.
> >> > >> + */
> >> > >> +struct gnttab_cache_flush {
> >> > >> +    union {
> >> > >> +        uint64_t dev_bus_addr;
> >> > >> +        grant_ref_t ref;
> >> > >> +    } a;
> >> > >> +    uint16_t offset; /* offset from start of grant */
> >> > >> +    uint16_t length; /* size within the grant */
> >> > > 
> >> > > So are these not valid when used with dev_bus_addr? I can see that being
> >> > > the case for offset, but length too?
> >> > 
> >> > Both ought to be valid, and dev_bus_addr should be page aligned.
> >> 
> >> That's right.
> > 
> > I would have expected you to correct the comment in the repost then
> > (which I notice also still says arm in the subject)
> 
> I have to admit I'm having trouble seeing which of the comments
> you think is wrong/misleading.

start of grant/size within the grant, in the context of using
dev_bus_addr, seemed strange/inconsistent.

But you made me think again and of course dev_bus_addr is required to
refer to a granted page isn't it. So I retract that comment.

Is it not worth being explicit about dev_bus_addr being page aligned and
equal to something previously returned by a map operation?

Ian.