From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH ARM v8 2/4] mini-os: arm: interrupt controller Date: Tue, 21 Oct 2014 16:16:41 +0100 Message-ID: <1413904601.23337.50.camel@citrix.com> References: <1412328051-20015-1-git-send-email-talex5@gmail.com> <1412328051-20015-3-git-send-email-talex5@gmail.com> <1413889218.23337.24.camel@citrix.com> <54466D06.5070000@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XgbCv-0003N9-0t for xen-devel@lists.xenproject.org; Tue, 21 Oct 2014 15:18:45 +0000 In-Reply-To: <54466D06.5070000@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Thomas Leonard , Dave.Scott@eu.citrix.com, anil@recoil.org, stefano.stabellini@eu.citrix.com, xen-devel@lists.xenproject.org, samuel.thibault@ens-lyon.org List-Id: xen-devel@lists.xenproject.org On Tue, 2014-10-21 at 15:26 +0100, Julien Grall wrote: > Our implementation of ITARGETSR doesn't handle correctly read/write per > byte. If the register is RO (such as for the SGIs and PPIs), our write > ignore is checking that the guest is writing a word. That's a bug. > Even though we need to fix it in Xen (I could send a patch for it). We > need to keep this implementation if we want mini-os to run on Xen 4.4.x. We should fix bugs, not workaround them in the guest.