From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OPW PATCH V3] tools: xl: refactor code to parse network device options Date: Tue, 21 Oct 2014 16:29:46 +0100 Message-ID: <1413905386.23337.53.camel@citrix.com> References: <1413901175-12026-1-git-send-email-alecsandrasandulescu@gmail.com> <20141021152420.GI10234@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XgbPn-0004Ow-OK for xen-devel@lists.xenproject.org; Tue, 21 Oct 2014 15:32:03 +0000 In-Reply-To: <20141021152420.GI10234@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: xen-devel@lists.xenproject.org, Alexandra Sandulescu , Alexandra Sandulescu List-Id: xen-devel@lists.xenproject.org On Tue, 2014-10-21 at 16:24 +0100, Wei Liu wrote: > Now we are in freeze, not sure how applicable is it for this patch to go > in. > > To Konrad: > > -ve: this is only code refactoring, not bug fix > +ve: the risk of introducing bug is low as 1) this refactoring is > straight-forward, 2) the code path is tested in OSSTest. Note that this was a task I suggested as part of the OPW application process. I said to Alexandra at the time: I think OPW wants you to get a patch accepted as part of the application process, however Xen is currently in code freeze for the 4.5 release so I think we will have to aim for a patch in a state where it could/would be accepted if there was no code freeze. The patch can then be held until the 4.6 development cycle opens and be applied then. Of course if the patch was allowed in now that would be awesome too ;-) Ian.