From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [RFC PATCH v2 10/12] cpufreq: add dom0-cpufreq
 driver
Date: Wed, 22 Oct 2014 12:00:31 +0100
Message-ID: <1413975631.18118.11.camel@citrix.com>
References: <1413458826-7248-1-git-send-email-oleksandr.dmytryshyn@globallogic.com>
	<1413458826-7248-11-git-send-email-oleksandr.dmytryshyn@globallogic.com>
	<54412FC1020000780003F997@mail.emea.novell.com>
	<CAN58jitMA69VfQv7GN8GQAxu4kmkf2h6M-EP=yWJ2C=b-OMseA@mail.gmail.com>
	<5447956E0200007800040EB3@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5447956E0200007800040EB3@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Tim Deegan <tim@xen.org>, Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>, Stefano Stabellini <stefano.stabellini@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-10-22 at 10:30 +0100, Jan Beulich wrote:
> >>> On 22.10.14 at 10:43, <oleksandr.dmytryshyn@globallogic.com> wrote:
> > On Fri, Oct 17, 2014 at 4:03 PM, Jan Beulich <JBeulich@suse.com> wrote:
> >>>>> On 16.10.14 at 13:27, <oleksandr.dmytryshyn@globallogic.com> wrote:
> >>> +static void notify_cpufreq_domains(void)
> >> Why "domains", not "hwdom"? You don't really want to send this
> >> to other than the hardware domain I hope.
> > All domains (not only hwdomain) should receive this interrupt.
> > In case is hwdomain is Linux kernel it can automaticaly recalculate
> > jiffies. But other domains should recalculate jiffies too. I'll
> > implement this mechanism a bit later.
> 
> This needs more explanation then: If all domains need to do
> adjustments when the frequency changes, there's something
> wrong here imo. Such changes are supposed to be visible to
> the hypervisor only (with, in the case here, assistance - but
> nothing else - by the hardware domain).

Guests should be using the arch/generic timers as their time source.
This is required by the hardware to increment at a fixed frequency, so
guests shouldn't need to be aware of the change to the underlying
processor clock, at least not for timekeeping/jiffies purposes.

The timers are allowed to increment by larger amounts less frequency in
lower power modes, i.e. +=4 every 4 ticks. Guests shouldn't need to
adjust anything for this though IMHO.

Ian.