From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for-xen-4-5 v3] xen/arm: dump guest stack
 even if not the current VCPU
Date: Thu, 23 Oct 2014 12:30:53 +0100
Message-ID: <1414063853.19198.42.camel@citrix.com>
References: <CAHt6W4eBBHNcAhhGBxWtfTHuUiqU2VZSftSz6H4KH=+KGdpu9Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAHt6W4eBBHNcAhhGBxWtfTHuUiqU2VZSftSz6H4KH=+KGdpu9Q@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Frediano Ziglio <freddy77@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>, xen-devel@lists.xen.org, Julien Grall <julien.grall@linaro.org>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-10-23 at 09:46 +0100, Frediano Ziglio wrote:
> From: Frediano Ziglio <frediano.ziglio@huawei.com>
> 
> If show_guest_stack was called from Xen context (for instance hitting
> '0' key on Xen console) get_page_from_gva was not able to get the
> page returning NULL.
> Detecting different domain and changing VTTBR register make
> get_page_from_gva works for different domains.
> 
> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>

Acked + applied (since Konrad said ok in v2).

> - collapse change in a single if to improve performances.

Not 100% keen on the duplicated call to gvirt_to_maddr, but it'll do.

Ian.