From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH for 4.5 v8 1/1] Add mmio_hole
Date: Thu, 23 Oct 2014 13:16:07 +0100
Message-ID: <1414066567.15687.1.camel@citrix.com>
References: <1413895346-31563-1-git-send-email-dslutz@verizon.com>
	<1413895346-31563-2-git-send-email-dslutz@verizon.com>
	<1413976876.19198.5.camel@citrix.com> <5447AC34.1030802@terremark.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5447AC34.1030802@terremark.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Don Slutz <dslutz@verizon.com>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, 2014-10-22 at 09:08 -0400, Don Slutz wrote:
> On 10/22/14 07:21, Ian Campbell wrote:
> > On Tue, 2014-10-21 at 08:42 -0400, Don Slutz wrote:
> >> If you add enough PCI devices then all mmio may not fit below 4G
> >> which may not be the layout the user wanted. This allows you to
> >> increase the below 4G address space that PCI devices can use and
> >> therefore in more cases not have any mmio that is above 4G.
> >>
> >> There are real PCI cards that do not support mmio over 4G, so if you
> >> want to emulate them precisely, you may also need to increase the
> >> space below 4G for them. There are drivers for these cards that also
> >> do not work if they have their mmio space mapped above 4G.
> >>
> >> This allows growing the MMIO hole to the size needed.
> >>
> >> This may help with using pci passthru and HVM.
> >>
> >> In the tools this is named mmio_hole_memkb.
> >>
> >> Signed-off-by: Don Slutz <dslutz@verizon.com>
> > For the tools side: Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > Has this had a release exception? Or acks for the hvmloader side of
> > things?
> >
> 
> On Tue, 14 Oct 2014 11:56:22 -0400, Konrad Rzeszutek Wilk said:
> 
> > I am OK with this patch going in Xen 4.5 (as a release-manager)
> > but it can't go anywhere unless there is an Ack/Review.
> 
> 
> On Mon, 20 Oct 2014 15:10:25 +0100, George Dunlap said:
> 
> > I haven't done a full review, but all of my previous concerns have
> > been addressed:
> 
> > Acked-by: George Dunlap <george.dunlap@eu.citrix.com>

Thanks, applied. I had to fix a warning due to the use of PRIu64 to
print an unsigned long (printf format error on x86_64 and arm32).

I changed the title to "x86: hvm: Allow configuration of the size of the
mmio_hole." since "Add mmio_hole".


Ian.