From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse
 network device options
Date: Thu, 23 Oct 2014 22:20:58 +0100
Message-ID: <1414099258.20604.84.camel@citrix.com>
References: <1413927381-21549-1-git-send-email-alecsandra.sandulescu@gmail.com>
	<1413977758.19198.12.camel@citrix.com>
	<20141022202146.GB6020@laptop.dumpdata.com>
	<1414050974.20604.79.camel@citrix.com>
	<3C254340-3D3F-4744-81FA-D9E65450D9A4@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XhPod-0001Bp-3R
	for xen-devel@lists.xenproject.org; Thu, 23 Oct 2014 21:21:06 +0000
In-Reply-To: <3C254340-3D3F-4744-81FA-D9E65450D9A4@oracle.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: xen-devel@lists.xenproject.org, wei.liu2@citrix.com, Alexandra Sandulescu <alecsandra.sandulescu@gmail.com>, konrad@darnok.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2014-10-23 at 16:08 -0400, Konrad Rzeszutek Wilk wrote:
> On October 23, 2014 3:56:14 AM EDT, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> >On Wed, 2014-10-22 at 16:21 -0400, Konrad Rzeszutek Wilk wrote:
> >> On Wed, Oct 22, 2014 at 12:35:58PM +0100, Ian Campbell wrote:
> >> > On Wed, 2014-10-22 at 00:36 +0300, Alexandra Sandulescu wrote:
> >> > > This patch removes duplicate code in /tools/libxl/xl_cmdimpl.c by
> >> > > adding parse_nic_config function. This function parses
> >configuration
> >> > > data and adds the information into libxl_device_nic struct. It is
> >> > > called in both main_networkattach and parse_config_data functions
> >> > > to replace duplicate code.
> >> > > 
> >> > > Signed-off-by: Alexandra Sandulescu
> ><alecsandra.sandulescu@gmail.com>
> >> > > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >> > 
> >> > This looks good to me, thanks. In reply to the first posting I
> >asked:
> >> > Did you test both code paths? (wrt cfg file vs xl network-attach
> >usage).
> >> > Did you?
> >> > 
> >> > Konrad, any reply to Wei's pros/cons on this patch for 4.5?
> >> > (<20141021152420.GI10234@zion.uk.xensource.com>)
> >> 
> >> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> >> 
> >> I am making this based on the fact that:
> >>  - It has run through the OSSTest which does a ton of tests so the
> >>    chance of regression is almost nill.
> >
> >You mean "will", not "has", right? Since it won't be run through
> >osstest
> >until it is committed.
> 
> Has. Wei said it had run through it.

Do you mean when he said "2) the code path is tested in OSSTest." ?

He said the code *path*, not the code, IOW I would read that as "would
be tested", NOT "has been tested".

Ian.