From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH for-4.5] EFI: Always use EFI command line Date: Fri, 24 Oct 2014 07:43:45 +0100 Message-ID: <1414133025.20604.89.camel@citrix.com> References: <1414109782-22961-1-git-send-email-roy.franz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1414109782-22961-1-git-send-email-roy.franz@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roy Franz Cc: tim@xen.org, stefano.stabellini@citrix.com, fu.wei@linaro.org, jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Thu, 2014-10-23 at 17:16 -0700, Roy Franz wrote: > This patch changes the ARM EFI boot code to always use the EFI commandline, > even when loaded by GRUB, which makes it consistent with Linux EFI booting. > The code previously incorrectly skipped processing of the EFI command line when > modules are present in the loader supplied FDT and the config file is not used. > There is no change in behavior for x86 since it unconditionally uses the config > file. > > Signed-off-by: Roy Franz Please can you update whichever of the docs are relevant as part of this patch i.e. One or more of misc/arm/booting.txt, misc/arm/device-tree/booting.txt or misc/efi.markdown might plausibly need updates to describe the new precedence for where a command line will be taken from. http://wiki.xen.org/wiki/Xen_ARM_with_Virtualization_Extensions/Multiboot will also need updating at some point. How does this interact with the presence/absence of a config file and any potential options= in that? What about the "efi options" like "-cfg=" which are currently handled from the UEFI command line, are they still correctly handled? (looks like the others are -help and -basevideo) Ian.