From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse
 network device options
Date: Fri, 24 Oct 2014 10:02:15 +0100
Message-ID: <1414141335.15687.15.camel@citrix.com>
References: <1413927381-21549-1-git-send-email-alecsandra.sandulescu@gmail.com>
	<1413977758.19198.12.camel@citrix.com>
	<20141022202146.GB6020@laptop.dumpdata.com>
	<1414050974.20604.79.camel@citrix.com>
	<3C254340-3D3F-4744-81FA-D9E65450D9A4@oracle.com>
	<1414099258.20604.84.camel@citrix.com>
	<CAPbh3ruo9H+tRxu08RkBMgEWGb5zZxv05y6oKcW5QtY-_Xm5eQ@mail.gmail.com>
	<1414137663.3584.5.camel@citrix.com>
	<CAAcqHeh8cFDa-dP_2Znt0J3-iZhSamZrGrmfxfEyF_rT4Dj_Dw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1XhalS-0006wF-60
	for xen-devel@lists.xenproject.org; Fri, 24 Oct 2014 09:02:30 +0000
In-Reply-To: <CAAcqHeh8cFDa-dP_2Znt0J3-iZhSamZrGrmfxfEyF_rT4Dj_Dw@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Alexandra Sandulescu <alecsandra.sandulescu@gmail.com>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-10-24 at 11:58 +0300, Alexandra Sandulescu wrote:

Please don't top post on the xen-devel list.

> I have tested stuff by hand (I took the code and created some
> structures - a bit of workaround let's say).

What do you mean here? Have you run the xl command on a real Xen system
with these patch applied?

>  Should I test it with OSSTest too?

If you've tested manually on a real Xen system I don't think this is
necessary, although if you are interested in getting osstest going then
I am quite happy to offer guidance where necessary.

> What I understood from Wei is that he tested my patch. Maybe I got it
> wrong.

That's not how I understood his comment, but I'll let him clarify.

Ian.