From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [OPW PATCH V4] tools: xl: refactor code to parse
 network device options
Date: Fri, 24 Oct 2014 10:14:02 +0100
Message-ID: <1414142042.15687.19.camel@citrix.com>
References: <1413927381-21549-1-git-send-email-alecsandra.sandulescu@gmail.com>
	<1413977758.19198.12.camel@citrix.com>
	<20141022202146.GB6020@laptop.dumpdata.com>
	<1414050974.20604.79.camel@citrix.com>
	<3C254340-3D3F-4744-81FA-D9E65450D9A4@oracle.com>
	<1414099258.20604.84.camel@citrix.com>
	<CAPbh3ruo9H+tRxu08RkBMgEWGb5zZxv05y6oKcW5QtY-_Xm5eQ@mail.gmail.com>
	<1414137663.3584.5.camel@citrix.com>
	<CAAcqHeh8cFDa-dP_2Znt0J3-iZhSamZrGrmfxfEyF_rT4Dj_Dw@mail.gmail.com>
	<1414141335.15687.15.camel@citrix.com>
	<CAAcqHei3SkfDy=diXSJXjqf+Sbhe66BA2HG3ZozkaOfgUhniYA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Ian.Campbell@citrix.com>) id 1Xhawg-0007VW-Rc
	for xen-devel@lists.xenproject.org; Fri, 24 Oct 2014 09:14:06 +0000
In-Reply-To: <CAAcqHei3SkfDy=diXSJXjqf+Sbhe66BA2HG3ZozkaOfgUhniYA@mail.gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Alexandra Sandulescu <alecsandra.sandulescu@gmail.com>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-10-24 at 12:12 +0300, Alexandra Sandulescu wrote:
> No I did not. I was easier to test the functions. I used the expected
> arguments from .cfg and for networkattach command.
> 
> If you want to test using the xl command, I will.
> 
> It looked a bit too much for me because  my patch does not really
> introduce new code.

Part of the purpose of this stage of the application process is not just
to change the code but also to start to gain familiarity with the Xen
system and set on up etc.

Although testing the functions in isolation can sometimes be OK I think
given the above it would preferred to setup an actual Xen system and run
the code in a real environment.

Ian.