From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@citrix.com>
Subject: Re: [PATCH] stubdom/Makefile should use
 QEMU_TRADITIONAL_LOC
Date: Fri, 24 Oct 2014 10:49:30 +0100
Message-ID: <1414144170.15687.29.camel@citrix.com>
References: <alpine.DEB.2.00.1410231825480.24944@procyon.dur.ac.uk>
	<20141024094457.GB15988@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20141024094457.GB15988@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: xen-devel@lists.xen.org, Ian Jackson <ian.jackson@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, M A Young <m.a.young@durham.ac.uk>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2014-10-24 at 10:44 +0100, Wei Liu wrote:
> On Thu, Oct 23, 2014 at 06:37:43PM +0100, M A Young wrote:
> > In http://xenbits.xenproject.org/gitweb/?p=xen.git;a=commit;h=8962a8f951ea83e8d10ee23aeb20266e4795b06e
> > CONFIG_QEMU was replaced by QEMU_TRADITIONAL_LOC in several places but not
> > in stubdom/Makefile, and as a result building stubdom is likely to fail when
> > xen-setup-stubdom isn't found. This patch replaces CONFIG_QEMU with
> > QEMU_TRADITIONAL_LOC in stubdom/Makefile as well.
> > 
> 
> While I understand the rationale behind this change, I'm a bit confused
> by the description. What does it mean by "is likely to fail"? Does it
> mean it succeeds sometimes and fails sometimes?
> 
> What's your build setup? I'm wondering why this is not caught in
> OSSTest.

Is it that osstest builds the regular tools first (and hence clones the
tree) before hitting the stubdom build whereas if you do the stubdom
build in isolation this doesn't happen?

> 
> Wei.
> 
> > 	Michael Young
> 
> > In commit 8962a8f951ea83e8d10ee23aeb20266e4795b06e CONFIG_QEMU was replaced
> > by QEMU_TRADITIONAL_LOC. However stubdom/Makefile still uses CONFIG_QEMU so
> > building stubdom is likely to fail.
> > This patch replaces CONFIG_QEMU with QEMU_TRADITIONAL_LOC in stubdom/Makefile
> > as well.
> > 
> > Signed-off-by: Michael Young <m.a.young@durham.ac.uk>
> > 
> > --- xen-4.5.0/stubdom/Makefile.orig	2014-10-22 21:07:26.000000000 +0100
> > +++ xen-4.5.0/stubdom/Makefile	2014-10-22 22:59:40.732112287 +0100
> > @@ -263,7 +263,7 @@
> >  .PHONY: $(CROSS_ROOT)
> >  $(CROSS_ROOT): cross-newlib cross-zlib cross-libpci
> >  
> > -QEMU_ROOT := $(shell if [ -d "$(CONFIG_QEMU)" ]; then echo "$(CONFIG_QEMU)"; else echo .; fi)
> > +QEMU_ROOT := $(shell if [ -d "$(QEMU_TRADITIONAL_LOC)" ]; then echo "$(QEMU_TRADITIONAL_LOC)"; else echo .; fi)
> >  
> >  ifneq ($(filter ioemu,$(STUBDOM_TARGETS)),)
> >  IOEMU_LINKFARM_TARGET := ioemu/linkfarm.stamp
> 
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>